Skip to content

T dannhauer additional tests for horde/url #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TDannhauer wants to merge 3 commits into
base: FRAMEWORK_6_0
Choose a base branch
from
Open

T dannhauer additional tests for horde/url #3

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a888d82
Create HordeUrlParamRawModeTest.php
TDannhauer Aug 13, 2025
fe9b5bd
Create NestedParamHordeUrlTest.php
TDannhauer Aug 13, 2025
d574b89
Create StringableParamTest.php
TDannhauer Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions test/Horde/Url/StringableParamTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<?php
/**
* @author Torben Dannhauer / GPT-5
* @license http://www.horde.org/licenses/lgpl21 LGPL 2.1
* @category Horde
* @package Url
* @subpackage UnitTests
*/

namespace Horde\Url;
use \PHPUnit\Framework\TestCase;
use \Horde_Url;

class StringableParamTest extends TestCase
{
private function getStringableObject($value)
{
return new class($value) {
private $value;
public function __construct($value) { $this->value = $value; }
public function __toString() { return (string)$this->value; }
};
}
Copy link

Copilot AI Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method uses tabs for indentation which is inconsistent with PSR-12 coding standards that recommend 4 spaces.

Suggested change
}
private function getStringableObject($value)
{
return new class($value) {
private $value;
public function __construct($value) { $this->value = $value; }
public function __toString() { return (string)$this->value; }
};
}

Copilot uses AI. Check for mistakes.

public function testStringableObjectAsParamValue()
{
$this->markTestIncomplete('Generalized normalization for all stringable objects may be implemented later.');
$url = new Horde_Url('test');
$url->add('s', $this->getStringableObject('a&b'));
// Current implementation only normalizes Horde_Url instances; generic stringables are not cast explicitly.
// Keep test incomplete until generalized handling is agreed upon.
}
Copy link
Contributor

@amulet1 amulet1 Aug 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to make it truly universal? Then I guess we need to check for presence of __toString method (see my other comments also). Are we okay with using ReflectionClass::hasMethodor method_exists (instead of explicit conversion)?

Copy link
Contributor Author

@TDannhauer TDannhauer Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest PHP is not my home run, so I do not feel experienced enough for the decisions there. @ralflang what do you think?

}
Loading