Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screw holes #267

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Screw holes #267

wants to merge 16 commits into from

Conversation

nellump
Copy link
Contributor

@nellump nellump commented Feb 3, 2022

Three example screw hole parts, for review. Ref. issue #266.

Just M3 and M4, for now.  More (both metric and imperial) to come.
Plus other miscellaneous adjustments to the screw hole symbol, etc.
Accidentally deleted the part's JSON file prior to previous commit.
1. Removed parameter program (unnecessarily complicated).  Replaced
   "keep-out" parametric polygon on assembly layer with manually drawn
   line circle.

2. Added matching line circles on top and bottom silkscreen layers.

3. Fixed reference and value designators (to make rules checks happy).

4. Added reference dimensions for mechanical hole and keep-out circle.
1. Set flags, suitable for non-electrical parts.
2. Edited description.
@carrotIndustries
Copy link
Member

Bot! please

@github-actions

This comment has been minimized.

@github-actions github-actions bot added the bot: warn At least one check resulted in warning label Feb 3, 2022
@nellump
Copy link
Contributor Author

nellump commented Feb 5, 2022

Bot! check my work

@github-actions

This comment has been minimized.

@github-actions github-actions bot added bot: fail At least one check failed and removed bot: warn At least one check resulted in warning labels Feb 5, 2022
@nellump
Copy link
Contributor Author

nellump commented Feb 5, 2022

Not sure how I managed to double up on the courtyard polygons.

Do we care about the "Unit has no pins!" flag?

@nellump
Copy link
Contributor Author

nellump commented Feb 7, 2022

Bot!

@github-actions

This comment has been minimized.

@github-actions github-actions bot added bot: pass All checks passed and removed bot: fail At least one check failed labels Feb 7, 2022
@carrotIndustries
Copy link
Member

LGTM apart from the naming. Why not name it "Screw hole, M3"? Putting "hole" in the tags should make it easier to find.

@nellump
Copy link
Contributor Author

nellump commented Feb 8, 2022 via email

Also cleaned up names, tags on existing screw hole packages.
@nellump
Copy link
Contributor Author

nellump commented Feb 9, 2022

Bot! find my mistakes

@nellump
Copy link
Contributor Author

nellump commented Feb 9, 2022

Matching parts would be useful. sigh Please stand by...

@github-actions

This comment has been minimized.

@nellump
Copy link
Contributor Author

nellump commented Feb 9, 2022

Bot! for reals this time

@github-actions

This comment has been minimized.

Some had version set to 1.  Unreleased parts should have version 0.
@nellump
Copy link
Contributor Author

nellump commented Feb 9, 2022

Bot!

@github-actions

This comment has been minimized.

@nellump
Copy link
Contributor Author

nellump commented Feb 9, 2022

Bot! tell me I'm done

@github-actions

This comment has been minimized.

@github-actions github-actions bot added bot: fail At least one check failed and removed bot: pass All checks passed labels Feb 9, 2022
@nellump
Copy link
Contributor Author

nellump commented Feb 9, 2022

Bot!

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

This review is brought to you by the Horizon EDA Poolbot commit eb40288.

Items in this PR

State Type Name Checks Version Filename
New Entity screw hole ✔️ Pass 0 ✔️ entities/mechanical/screw_hole.json
New Package screw hole, M2.5 ✔️ Pass 0 ✔️ packages/mechanical/screw_holes/m2.5/package.json
New Package screw hole, M2 ✔️ Pass 0 ✔️ packages/mechanical/screw_holes/m2/package.json
New Package screw hole, M3 ✔️ Pass 0 ✔️ packages/mechanical/screw_holes/m3/package.json
New Package screw hole, M4 ✔️ Pass 0 ✔️ packages/mechanical/screw_holes/m4/package.json
New Package screw hole, M5 ✔️ Pass 0 ✔️ packages/mechanical/screw_holes/m5/package.json
New Package screw hole, M6 ✔️ Pass 0 ✔️ packages/mechanical/screw_holes/m6/package.json
New Package screw hole, M8 ✔️ Pass 0 ✔️ packages/mechanical/screw_holes/m8/package.json
New Package screw hole, UTS #0 ✔️ Pass 0 ✔️ packages/mechanical/screw_holes/uts0/package.json
New Package screw hole, UTS #1 ✔️ Pass 0 ✔️ packages/mechanical/screw_holes/uts1/package.json
New Package screw hole, UTS #10 ✔️ Pass 0 ✔️ packages/mechanical/screw_holes/uts10/package.json
New Package screw hole, UTS #2 ✔️ Pass 0 ✔️ packages/mechanical/screw_holes/uts2/package.json
New Package screw hole, UTS #3 ✔️ Pass 0 ✔️ packages/mechanical/screw_holes/uts3/package.json
New Package screw hole, UTS #4 ✔️ Pass 0 ✔️ packages/mechanical/screw_holes/uts4/package.json
New Package screw hole, UTS #5 ✔️ Pass 0 ✔️ packages/mechanical/screw_holes/uts5/package.json
New Package screw hole, UTS #6 ✔️ Pass 0 ✔️ packages/mechanical/screw_holes/uts6/package.json
New Package screw hole, UTS #8 ✔️ Pass 0 ✔️ packages/mechanical/screw_holes/uts8/package.json
New Package screw hole, UTS 5/16" ✔️ Pass 0 ✔️ packages/mechanical/screw_holes/uts_five_sixteenths_in/package.json
New Package screw hole, UTS 1/4" ✔️ Pass 0 ✔️ packages/mechanical/screw_holes/uts_one_quarter_in/package.json
New Part screw hole, M2.5 ✔️ Pass 0 ✔️ parts/mechanical/screw_holes/m2.5.json
New Part screw hole, M2 ✔️ Pass 0 ✔️ parts/mechanical/screw_holes/m2.json
New Part screw hole, M3 ✔️ Pass 0 ✔️ parts/mechanical/screw_holes/m3.json
New Part screw hole, M4 ✔️ Pass 0 ✔️ parts/mechanical/screw_holes/m4.json
New Part screw hole, M5 ✔️ Pass 0 ✔️ parts/mechanical/screw_holes/m5.json
New Part screw hole, M6 ✔️ Pass 0 ✔️ parts/mechanical/screw_holes/m6.json
New Part screw hole, M8 ✔️ Pass 0 ✔️ parts/mechanical/screw_holes/m8.json
New Part screw hole, #0 ✔️ Pass 0 ✔️ parts/mechanical/screw_holes/uts0.json
New Part screw hole, #1 ✔️ Pass 0 ✔️ parts/mechanical/screw_holes/uts1.json
New Part screw hole, #10 ✔️ Pass 0 ✔️ parts/mechanical/screw_holes/uts10.json
New Part screw hole, #2 ✔️ Pass 0 ✔️ parts/mechanical/screw_holes/uts2.json
New Part screw hole, #3 ✔️ Pass 0 ✔️ parts/mechanical/screw_holes/uts3.json
New Part screw hole, #4 ✔️ Pass 0 ✔️ parts/mechanical/screw_holes/uts4.json
New Part screw hole, #5 ✔️ Pass 0 ✔️ parts/mechanical/screw_holes/uts5.json
New Part screw hole, #6 ✔️ Pass 0 ✔️ parts/mechanical/screw_holes/uts6.json
New Part screw hole, #8 ✔️ Pass 0 ✔️ parts/mechanical/screw_holes/uts8.json
New Part screw hole, 5/16" ✔️ Pass 0 ✔️ parts/mechanical/screw_holes/uts_five_sixteenths_in.json
New Part screw hole, 1/4" ✔️ Pass 0 ✔️ parts/mechanical/screw_holes/uts_one_quarter_in.json
New Symbol screw hole ✔️ Pass 0 ✔️ symbols/mechanical/screw_hole.json
New Unit screw hole ✔️ Pass 0 ✔️ units/mechanical/screw_hole.json

Non-items

  • packages/mechanical/screw_holes/m8/package.json.bak

Parts overview (excluding derived)

Bold items are from this PR

Details

Parts

screw hole, #10

✔️ Checks passed

Attribute Value
MPN screw hole, #10
Value
Manufacturer (141 other parts)
Datasheet
Description UTS #10 screw hole, unplated
Tags hole mechanical

Flags

  • Exclude from BOM
  • Exclude from Pick&Place
Pad Gate Pin

screw hole, #4

✔️ Checks passed

Attribute Value
MPN screw hole, #4
Value
Manufacturer (141 other parts)
Datasheet
Description UTS #4 screw hole, unplated
Tags hole mechanical

Flags

  • Exclude from BOM
  • Exclude from Pick&Place
Pad Gate Pin

screw hole, #3

✔️ Checks passed

Attribute Value
MPN screw hole, #3
Value
Manufacturer (141 other parts)
Datasheet
Description UTS #3 screw hole, unplated
Tags hole mechanical

Flags

  • Exclude from BOM
  • Exclude from Pick&Place
Pad Gate Pin

screw hole, 5/16"

✔️ Checks passed

Attribute Value
MPN screw hole, 5/16"
Value
Manufacturer (141 other parts)
Datasheet
Description UTS 5/16" screw hole, unplated
Tags hole mechanical

Flags

  • Exclude from BOM
  • Exclude from Pick&Place
Pad Gate Pin

screw hole, #2

✔️ Checks passed

Attribute Value
MPN screw hole, #2
Value
Manufacturer (141 other parts)
Datasheet
Description UTS #2 screw hole, unplated
Tags hole mechanical

Flags

  • Exclude from BOM
  • Exclude from Pick&Place
Pad Gate Pin

screw hole, M5

✔️ Checks passed

Attribute Value
MPN screw hole, M5
Value M5
Manufacturer (141 other parts)
Datasheet
Description M5 screw hole, unplated
Tags hole mechanical

Flags

  • Exclude from BOM
  • Exclude from Pick&Place
Pad Gate Pin

screw hole, M6

✔️ Checks passed

Attribute Value
MPN screw hole, M6
Value
Manufacturer (141 other parts)
Datasheet
Description M6 screw hole, unplated
Tags hole mechanical

Flags

  • Exclude from BOM
  • Exclude from Pick&Place
Pad Gate Pin

screw hole, M3

✔️ Checks passed

Attribute Value
MPN screw hole, M3
Value M3
Manufacturer (141 other parts)
Datasheet
Description M3 screw hole, unplated
Tags hole mechanical

Flags

  • Exclude from BOM
  • Exclude from Pick&Place
Pad Gate Pin

screw hole, #0

✔️ Checks passed

Attribute Value
MPN screw hole, #0
Value
Manufacturer (141 other parts)
Datasheet
Description UTS #0 screw hole, unplated
Tags hole mechanical

Flags

  • Exclude from BOM
  • Exclude from Pick&Place
Pad Gate Pin

screw hole, #8

✔️ Checks passed

Attribute Value
MPN screw hole, #8
Value
Manufacturer (141 other parts)
Datasheet
Description UTS #8 screw hole, unplated
Tags hole mechanical

Flags

  • Exclude from BOM
  • Exclude from Pick&Place
Pad Gate Pin

screw hole, #1

✔️ Checks passed

Attribute Value
MPN screw hole, #1
Value
Manufacturer (141 other parts)
Datasheet
Description UTS #1 screw hole, unplated
Tags hole mechanical

Flags

  • Exclude from BOM
  • Exclude from Pick&Place
Pad Gate Pin

screw hole, M2

✔️ Checks passed

Attribute Value
MPN screw hole, M2
Value
Manufacturer (141 other parts)
Datasheet
Description M2 screw hole, unplated
Tags hole mechanical

Flags

  • Exclude from BOM
  • Exclude from Pick&Place
Pad Gate Pin

screw hole, M2.5

✔️ Checks passed

Attribute Value
MPN screw hole, M2.5
Value
Manufacturer (141 other parts)
Datasheet
Description M2.5 screw hole, unplated
Tags hole mechanical

Flags

  • Exclude from BOM
  • Exclude from Pick&Place
Pad Gate Pin

screw hole, 1/4"

✔️ Checks passed

Attribute Value
MPN screw hole, 1/4"
Value
Manufacturer (141 other parts)
Datasheet
Description UTS 1/4" screw hole, unplated
Tags hole mechanical

Flags

  • Exclude from BOM
  • Exclude from Pick&Place
Pad Gate Pin

screw hole, #6

✔️ Checks passed

Attribute Value
MPN screw hole, #6
Value
Manufacturer (141 other parts)
Datasheet
Description UTS #6 screw hole, unplated
Tags hole mechanical

Flags

  • Exclude from BOM
  • Exclude from Pick&Place
Pad Gate Pin

screw hole, M8

✔️ Checks passed

Attribute Value
MPN screw hole, M8
Value
Manufacturer (141 other parts)
Datasheet
Description M8 screw hole, unplated
Tags hole mechanical

Flags

  • Exclude from BOM
  • Exclude from Pick&Place
Pad Gate Pin

screw hole, #5

✔️ Checks passed

Attribute Value
MPN screw hole, #5
Value
Manufacturer (141 other parts)
Datasheet
Description UTS #5 screw hole, unplated
Tags hole mechanical

Flags

  • Exclude from BOM
  • Exclude from Pick&Place
Pad Gate Pin

screw hole, M4

✔️ Checks passed

Attribute Value
MPN screw hole, M4
Value M4
Manufacturer (141 other parts)
Datasheet
Description M4 screw hole, unplated
Tags hole mechanical

Flags

  • Exclude from BOM
  • Exclude from Pick&Place
Pad Gate Pin

Entities

screw hole

✔️ Checks passed

Attribute Value
Manufacturer (141 other parts)
Prefix MH
Tags hole mechanical
Gate Suffix Swap group Unit
Main 0 screw hole

Units

screw hole

✔️ Checks passed

Attribute Value
Manufacturer (141 other parts)

❌ Unit has no pins!

Symbol: screw hole

✔️ Checks passed

  • Is box symbol

Symbol

Packages

screw hole, M2.5

Attribute Value
Manufacturer (141 other parts)
Tags hole mechanical

✔️ Package checks passed

✔️ Clearance checks passed

Package

Parameters
Parameter Value
Courtyard expansion 000.250 mm
6.000mm 6.000mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]
Pads
Pad Padstack Hole diameter
1 Circular mechanical Hole 002.900 mm
3D views (no models)

Without model

Top Bottom
3D 3D

screw hole, M2

Attribute Value
Manufacturer (141 other parts)
Tags hole mechanical

✔️ Package checks passed

✔️ Clearance checks passed

Package

Parameters
Parameter Value
Courtyard expansion 000.250 mm
5.000mm 5.000mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]
Pads
Pad Padstack Hole diameter
1 Circular mechanical Hole 002.400 mm
3D views (no models)

Without model

Top Bottom
3D 3D

screw hole, M3

Attribute Value
Manufacturer (141 other parts)
Tags hole mechanical

✔️ Package checks passed

✔️ Clearance checks passed

Package

Parameters
Parameter Value
Courtyard expansion 000.250 mm
7.00mm 7.00mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]
Pads
Pad Padstack Hole diameter
1 Circular mechanical Hole 003.400 mm
3D views (no models)

Without model

Top Bottom
3D 3D

screw hole, M4

Attribute Value
Manufacturer (141 other parts)
Tags hole mechanical

✔️ Package checks passed

✔️ Clearance checks passed

Package

Parameters
Parameter Value
Courtyard expansion 000.250 mm
9.000mm 9.000mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]
Pads
Pad Padstack Hole diameter
1 Circular mechanical Hole 004.500 mm
3D views (no models)

Without model

Top Bottom
3D 3D

screw hole, M5

Attribute Value
Manufacturer (141 other parts)
Tags hole mechanical

✔️ Package checks passed

✔️ Clearance checks passed

Package

Parameters
Parameter Value
Courtyard expansion 000.250 mm
11.000mm 11.000mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]
Pads
Pad Padstack Hole diameter
1 Circular mechanical Hole 005.500 mm
3D views (no models)

Without model

Top Bottom
3D 3D

screw hole, M6

Attribute Value
Manufacturer (141 other parts)
Tags hole mechanical

✔️ Package checks passed

✔️ Clearance checks passed

Package

Parameters
Parameter Value
Courtyard expansion 000.250 mm
13.000mm 13.000mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]
Pads
Pad Padstack Hole diameter
1 Circular mechanical Hole 006.600 mm
3D views (no models)

Without model

Top Bottom
3D 3D

screw hole, M8

Attribute Value
Manufacturer (141 other parts)
Tags hole mechanical

✔️ Package checks passed

✔️ Clearance checks passed

Package

Parameters
Parameter Value
Courtyard expansion 000.250 mm
18.000mm 18.000mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]
Pads
Pad Padstack Hole diameter
1 Circular mechanical Hole 009.000 mm
3D views (no models)

Without model

Top Bottom
3D 3D

screw hole, UTS #0

Attribute Value
Manufacturer (141 other parts)
Tags hole mechanical

✔️ Package checks passed

✔️ Clearance checks passed

Package

Parameters
Parameter Value
Courtyard expansion 000.250 mm
4.000mm 4.000mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]
Pads
Pad Padstack Hole diameter
1 Circular mechanical Hole 001.930 mm
3D views (no models)

Without model

Top Bottom
3D 3D

screw hole, UTS #1

Attribute Value
Manufacturer (141 other parts)
Tags hole mechanical

✔️ Package checks passed

✔️ Clearance checks passed

Package

Parameters
Parameter Value
Courtyard expansion 000.250 mm
5.000mm 5.000mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]
Pads
Pad Padstack Hole diameter
1 Circular mechanical Hole 002.261 mm
3D views (no models)

Without model

Top Bottom
3D 3D

screw hole, UTS #10

Attribute Value
Manufacturer (141 other parts)
Tags hole mechanical

✔️ Package checks passed

✔️ Clearance checks passed

Package

Parameters
Parameter Value
Courtyard expansion 000.250 mm
11.000mm 11.000mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]
Pads
Pad Padstack Hole diameter
1 Circular mechanical Hole 005.613 mm
3D views (no models)

Without model

Top Bottom
3D 3D

screw hole, UTS #2

Attribute Value
Manufacturer (141 other parts)
Tags hole mechanical

✔️ Package checks passed

✔️ Clearance checks passed

Package

Parameters
Parameter Value
Courtyard expansion 000.250 mm
5.000mm 5.000mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]
Pads
Pad Padstack Hole diameter
1 Circular mechanical Hole 002.591 mm
3D views (no models)

Without model

Top Bottom
3D 3D

screw hole, UTS #3

Attribute Value
Manufacturer (141 other parts)
Tags hole mechanical

✔️ Package checks passed

✔️ Clearance checks passed

Package

Parameters
Parameter Value
Courtyard expansion 000.250 mm
6.000mm 6.000mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]
Pads
Pad Padstack Hole diameter
1 Circular mechanical Hole 002.946 mm
3D views (no models)

Without model

Top Bottom
3D 3D

screw hole, UTS #4

Attribute Value
Manufacturer (141 other parts)
Tags hole mechanical

✔️ Package checks passed

✔️ Clearance checks passed

Package

Parameters
Parameter Value
Courtyard expansion 000.250 mm
7.000mm 7.000mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]
Pads
Pad Padstack Hole diameter
1 Circular mechanical Hole 003.251 mm
3D views (no models)

Without model

Top Bottom
3D 3D

screw hole, UTS #5

Attribute Value
Manufacturer (141 other parts)
Tags hole mechanical

✔️ Package checks passed

✔️ Clearance checks passed

Package

Parameters
Parameter Value
Courtyard expansion 000.250 mm
8.000mm 8.000mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]
Pads
Pad Padstack Hole diameter
1 Circular mechanical Hole 003.962 mm
3D views (no models)

Without model

Top Bottom
3D 3D

screw hole, UTS #6

Attribute Value
Manufacturer (141 other parts)
Tags hole mechanical

✔️ Package checks passed

✔️ Clearance checks passed

Package

Parameters
Parameter Value
Courtyard expansion 000.250 mm
9.000mm 9.000mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]
Pads
Pad Padstack Hole diameter
1 Circular mechanical Hole 004.318 mm
3D views (no models)

Without model

Top Bottom
3D 3D

screw hole, UTS #8

Attribute Value
Manufacturer (141 other parts)
Tags hole mechanical

✔️ Package checks passed

✔️ Clearance checks passed

Package

Parameters
Parameter Value
Courtyard expansion 000.250 mm
10.000mm 10.000mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]
Pads
Pad Padstack Hole diameter
1 Circular mechanical Hole 004.978 mm
3D views (no models)

Without model

Top Bottom
3D 3D

screw hole, UTS 5/16"

Attribute Value
Manufacturer (141 other parts)
Tags hole mechanical

✔️ Package checks passed

✔️ Clearance checks passed

Package

Parameters
Parameter Value
Courtyard expansion 000.250 mm
17.000mm 17.000mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]
Pads
Pad Padstack Hole diameter
1 Circular mechanical Hole 008.738 mm
3D views (no models)

Without model

Top Bottom
3D 3D

screw hole, UTS 1/4"

Attribute Value
Manufacturer (141 other parts)
Tags hole mechanical

✔️ Package checks passed

✔️ Clearance checks passed

Package

Parameters
Parameter Value
Courtyard expansion 000.250 mm
14.000mm 14.000mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]
Pads
Pad Padstack Hole diameter
1 Circular mechanical Hole 007.137 mm
3D views (no models)

Without model

Top Bottom
3D 3D

@github-actions github-actions bot added bot: pass All checks passed and removed bot: fail At least one check failed labels Feb 9, 2022
@carrotIndustries
Copy link
Member

packages/mechanical/screw_holes/m8/package.json.bak

shouldn't be in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: pass All checks passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants