Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds packages, base parts 3D models for 6.3mm Resistors #304

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

atoav
Copy link
Contributor

@atoav atoav commented Oct 26, 2022

As proposed by @carrotIndustries here I added the packages, 3D-models and base parts for 6.3mm through hole resistors (both horizontal and vertical orientations).

The base parts are actually altered variants of the ones I am using in my repo, as they have been including some Yageo-specific details. I will add did add these new base parts as the bases of my resistors-bases as well in order to make them compatible with the official pool.

The 3D-models (as mentioned already in the original PR #48) have been modelled by myself. I was toying with the idea of writing a script to add colored stripes, but reached the conclusion that the amount of data this would add would not be worth it. People who want that kind of detail in their 3D-models are better served with using textures and Blender anyways.

@RX14
Copy link
Collaborator

RX14 commented Oct 26, 2022

Bot!

@github-actions

This comment has been minimized.

@github-actions github-actions bot added the bot: fail At least one check failed label Oct 26, 2022
@atoav
Copy link
Contributor Author

atoav commented Oct 26, 2022

Btw. the silkscreen error is expected here. The TH part goes on top of the silkscreen. This error will also happen with the TO-220-3 and similar packages.

@RX14
Copy link
Collaborator

RX14 commented Oct 26, 2022

The same physical resistor is used for both horizontal and vertical parts, surely this should be a single base part with 2 alternate packages?

@atoav
Copy link
Contributor Author

atoav commented Oct 26, 2022

Now that you mention it, it makes a lot of sense. These packages have been very old, so it might be that back then the alternate package mechanism was not implemented yet (or, equally likely: it was implemented, but I did not know about it back then). Anyways I fixed it here, and I will fix it I did fix it in my repo as well.

I remembered it the wrong way around, sorry : /
@RX14
Copy link
Collaborator

RX14 commented Oct 26, 2022

Bot!

@github-actions
Copy link

This review is brought to you by the Horizon EDA Poolbot commit eb40288.

Items in this PR

State Type Name Checks Version Filename
New 3D Model Not run N/A 3d_models/passive/resistor/resistor_6.3mm_length_2.54mm_lead_space_vertical.stp
New 3D Model Not run N/A 3d_models/passive/resistor/resistor_6.3mm_length_8.75mm_lead_spacing.step
New Package Generic Resistor 6.3 mm Length ❌ Fail 0 ✔️ packages/passive/th/resistor/generic_6.3mm_length_resistor/package.json
New Package Generic Resistor 6.3 mm Length (Vertical) ❌ Fail 0 ✔️ packages/passive/th/resistor/generic_6.3mm_length_resistor_vertical/package.json
New Part 6.3mm Resistor Base Part ✔️ Pass 1 ✔️ parts/passive/resistor/base-th-6.3mm.json

Parts overview (excluding derived)

Bold items are from this PR

  • Part 6.3mm Resistor Base Part
    • Package Generic Resistor 6.3 mm Length
      • Padstack TH round
      • 3D Model 3d_models/passive/resistor/resistor_6.3mm_length_8.75mm_lead_spacing.step
    • Entity Two-terminal resistor
      • Unit Two-terminal resistor
        • Symbol EU Resistor

Items not associated with any part

  • Package Generic Resistor 6.3 mm Length (Vertical)

Details

Parts

6.3mm Resistor Base Part

✔️ Checks passed

Attribute Value
MPN 6.3mm Resistor Base Part
Value 6.3mm Resistor
Manufacturer (124 other parts)
Datasheet
Description Metal Film Resistor
Tags 6.3mm passive resistor th

Flags

  • Base part
Pad Gate Pin
1 Main A
2 Main B

Packages

Generic Resistor 6.3 mm Length

Attribute Value
Manufacturer (124 other parts)
Tags generic passive th

✔️ Package checks passed

Clearance checks didn't pass

  • ❌ Top Package near Top Silkscreen

Package

Parameters
Parameter Value
Courtyard expansion 000.250 mm
2.500mm 10.150mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]
Pads
Pad Padstack Pad diameter Hole diameter
1 TH round 001.400 mm 000.800 mm
2 TH round 001.400 mm 000.800 mm
3D views (one model)

Without model

Top Bottom
3D 3D

resistor_6.3mm_length_8.75mm_lead_spacing.step

Top Bottom
3D 3D
South East North West
3D 3D 3D 3D
Pitch analysis
X Y Count
000.000 mm 008.750 mm 2

Generic Resistor 6.3 mm Length (Vertical)

Attribute Value
Manufacturer (124 other parts)
Alt. for Generic Resistor 6.3 mm Length
Tags generic passive th

✔️ Package checks passed

Clearance checks didn't pass

  • ❌ Top Copper near Top Silkscreen
  • ❌ Top Package near Top Silkscreen

Package

Parameters
Parameter Value
Courtyard expansion 000.250 mm
2.00mm 4.0mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]
Pads
Pad Padstack Pad diameter Hole diameter
1 TH round 001.400 mm 000.800 mm
2 TH round 001.400 mm 000.800 mm
3D views (one model)

Without model

Top Bottom
3D 3D

resistor_6.3mm_length_2.54mm_lead_space_vertical.stp

Top Bottom
3D 3D
South East North West
3D 3D 3D 3D
Pitch analysis
X Y Count
000.000 mm 002.540 mm 2

@RX14
Copy link
Collaborator

RX14 commented Oct 26, 2022

  • Reference Designators should only be on the silkscreen and assembly layer
  • Assembly layer refdes should ahve a small enough font size to fit R1234 comfortably, the current text doesn't
  • The vertical package assembly layer refdes is a bit small, should probably be vertical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fail At least one check failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants