add bidir esd/tvs diode

[LHSmicius]

As always I have some questions :D
Unit
I names pins "1" and "2", because it's bidirectional - it would be not accurate to call pins "A" and "K".
Symbol
I marked pin 1 with "+" because even if it's bidirectional (from electrical view), ESD and TVS diodes often has not symmetric package. Maybe pad numbers are enough... IDK...

Package
Just noticed that there is not described in "Horizon Pool Convention" that Courtyard expansion should be 0.25mm. It would be nice to mention somewhere.

Part
Base part has no description (It doesn't make any sense), so bot will fail. I think we need exception for base parts.

[LHSmicius]

Bot!

[LHSmicius]

Bot!
Finally text placement is correct. Bot fails on base part which is good.

[LHSmicius]

Bot!

[github-actions]

This review is brought to you by the Horizon EDA Poolbot commit 33131f8.

Items in this PR

State	Type	Name	Checks	Version	Filename
New	Entity	ESD diode bidirectional	✔️ Pass	0 ✔️	entities/diode/esd_diode_bidirectional.json
New	Package	SOD523	✔️ Pass	0 ✔️	packages/diode/SOD523/package.json
New	Part	base SOD523 ESD diode bidirectional	❌ Fail	1 ✔️	parts/diode/base_SOD523_ESD_bidirectional.json
New	Part	DESD5V0U1BB	✔️ Pass	0 ✔️	parts/diode/tvs/DESD5V0U1BB.json
New	Symbol	ESD diode bidirectional	✔️ Pass	1 ✔️	symbols/diode/esd_diode_bidirectional.json
New	Unit	ESD diode bidirectional	✔️ Pass	0 ✔️	units/diode/esd_diode_bidirectional.json

Parts overview (excluding derived)

Bold items are from this PR

• Part base SOD523 ESD diode bidirectional
  • Package SOD523
    • Padstack SMD rectangular
  • Entity ESD diode bidirectional
    • Unit ESD diode bidirectional
      • Symbol ESD diode bidirectional

Derived parts

Bold items are from this PR

• base SOD523 ESD diode bidirectional
  • DESD5V0U1BB

Parts table

Values in italic are inherited

MPN	Value	Manufacturer	Datasheet	Description	Tags
base SOD523 ESD diode bidirectional					bidirectional diode esd smd tvs
DESD5V0U1BB		Diodes Inc.	https://www.diodes.com/assets/Datasheets/DESD5V0U1BB.pdf	Bidirectional TVS diode, 2.9pF	bidirectional diode esd smd tvs

Details

Parts

base SOD523 ESD diode bidirectional

Checks didn't pass

• ❌ Description must not be empty

Attribute	Value
MPN	base SOD523 ESD diode bidirectional
Value
Manufacturer	(125 other parts)
Datasheet
Description
Tags	bidirectional diode esd smd tvs

Flags

• Base part

Pad	Gate	Pin
1	Main	1
2	Main	2

DESD5V0U1BB

Inerhits from base SOD523 ESD diode bidirectional

✔️ Checks passed

Attribute	Value
MPN	DESD5V0U1BB
Value
Manufacturer	Diodes Inc. (39 other parts)
Datasheet	https://www.diodes.com/assets/Datasheets/DESD5V0U1BB.pdf
Description	Bidirectional TVS diode, 2.9pF
Tags	bidirectional diode esd smd tvs (inherited)

Orderable MPNs

• DESD5V0U1BB-7

Entities

ESD diode bidirectional

✔️ Checks passed

Attribute	Value
Manufacturer	(125 other parts)
Prefix	D
Tags	bidirectional diode esd tvs

Gate	Suffix	Swap group	Unit
Main		0	ESD diode bidirectional

Units

ESD diode bidirectional

✔️ Checks passed

Attribute	Value
Manufacturer	(125 other parts)

Pin	Direction
1	Passive
2	Passive

Symbol: ESD diode bidirectional

✔️ Checks passed

Angle	Normal	Mirrored
0°
90°
180°
270°

Packages

SOD523

Attribute	Value
Manufacturer	(125 other parts)
Tags	diode generic smd

✔️ Package checks passed

✔️ Clearance checks passed

Parameters

Parameter	Value
Courtyard expansion	000.250 mm

2.000mm 0.800mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]

Pads

Pad	Padstack	Pad width	Pad height
1	SMD rectangular	000.600 mm	000.700 mm
2	SMD rectangular	000.600 mm	000.700 mm

3D views (no models)

Without model

Top	Bottom

Pitch analysis

X	Y	Count
001.400 mm	000.000 mm	2

[RX14]

If in doubt, look at what other parts do! The other diodes in the pool all use A/K pin naming.

In regards to the + pin marking, I am sceptical but I haven't used any of these diodes so I trust you to choose a sensible course. Other passives don't tend to enable pin markings on their symbols.

I would consider rounding the pads of the SOD package.

[LHSmicius]

Changed pin names to A/K - you are right, even it's bidirectional, it makes more sense then naming 1/2.
Decided not to use "+" marking because it's non-standard and maybe it will bring more uncertainty.
Now I also think about round pads, it's easy to do, but then it will differs from other packages in the pool. I can make other PR and change all SOD packages to use round pads if needed

[RX14]

Newer parts to the pool all have round pads. Square or round pads is purely about the age of the part in the pool, nothing else. One day perhaps all the parts will have round pads

[LHSmicius]

Didn't find how to calculate corner radius, so for now used default 0.1 mm. If it's not correct, I will fix it.

[LHSmicius]

In last 2 commits I completely redraw footprint using horizon built-in footprint generator for SOD package. It looks a bit different from Diodes Inc suggestion. That's how footprint generator draws using package dimensions (attached datasheet screenshot upper side) as input parameters.