-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bidir esd/tvs diode #321
base: master
Are you sure you want to change the base?
Conversation
Bot! |
This comment has been minimized.
This comment has been minimized.
Bot! |
Bot! |
This review is brought to you by the Horizon EDA Poolbot commit 33131f8. Items in this PR
Parts overview (excluding derived)Bold items are from this PR
Derived partsBold items are from this PR
Parts tableValues in italic are inherited
DetailsPartsbase SOD523 ESD diode bidirectionalChecks didn't pass
Flags
DESD5V0U1BBInerhits from base SOD523 ESD diode bidirectional ✔️ Checks passed
Orderable MPNs
EntitiesESD diode bidirectional✔️ Checks passed
UnitsESD diode bidirectional✔️ Checks passed
Symbol: ESD diode bidirectional✔️ Checks passed
PackagesSOD523
✔️ Package checks passed ✔️ Clearance checks passed Parameters
Pads
Pitch analysis
|
If in doubt, look at what other parts do! The other diodes in the pool all use A/K pin naming. In regards to the + pin marking, I am sceptical but I haven't used any of these diodes so I trust you to choose a sensible course. Other passives don't tend to enable pin markings on their symbols. I would consider rounding the pads of the SOD package. |
Changed pin names to A/K - you are right, even it's bidirectional, it makes more sense then naming 1/2. |
Newer parts to the pool all have round pads. Square or round pads is purely about the age of the part in the pool, nothing else. One day perhaps all the parts will have round pads |
Didn't find how to calculate corner radius, so for now used default 0.1 mm. If it's not correct, I will fix it. |
As always I have some questions :D
![image](https://private-user-images.githubusercontent.com/46829407/245223469-84c57222-b228-4d85-9c86-11f0d80d5a2c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ5NzUwNTEsIm5iZiI6MTcyNDk3NDc1MSwicGF0aCI6Ii80NjgyOTQwNy8yNDUyMjM0NjktODRjNTcyMjItYjIyOC00ZDg1LTljODYtMTFmMGQ4MGQ1YTJjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI5VDIzMzkxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRiNzI1MmRkNWZjOWEwZTE0ZDY4YjVjNzU3NWEwYzg4YWY5NjlmYjc0YzIzNmNmNjg0NGM3MWNmNWNjYWEzYTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.V6YZ0sUahlFOT-g0Xd6bf33l2wQmWtVOzN0b1tsfsbo)
![image](https://private-user-images.githubusercontent.com/46829407/245224543-2a61b8dd-e1f4-4e62-8129-b4eb5f68b1b1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ5NzUwNTEsIm5iZiI6MTcyNDk3NDc1MSwicGF0aCI6Ii80NjgyOTQwNy8yNDUyMjQ1NDMtMmE2MWI4ZGQtZTFmNC00ZTYyLTgxMjktYjRlYjVmNjhiMWIxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI5VDIzMzkxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUwY2EwN2JjNmIyMTQzZjVjNDRmNWUxM2VhMzI0YTViY2RkZTM3ZjZiNTM5ZGUxOTk3NjhlZTgwY2MwODkzOGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.31YmTJ_RuudRUOU1N9-p8DGtT1KXBJ6nurbk-Z6_H7g)
Unit
I names pins "1" and "2", because it's bidirectional - it would be not accurate to call pins "A" and "K".
Symbol
I marked pin 1 with "+" because even if it's bidirectional (from electrical view), ESD and TVS diodes often has not symmetric package. Maybe pad numbers are enough... IDK...
Package
Just noticed that there is not described in "Horizon Pool Convention" that Courtyard expansion should be 0.25mm. It would be nice to mention somewhere.
Part
Base part has no description (It doesn't make any sense), so bot will fail. I think we need exception for base parts.