Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATmega328P-AU #322

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

alex-fu27
Copy link

@alex-fu27 alex-fu27 commented Jun 13, 2023

I would like to continue with @endofexclusive's pull request #138 . @carrotIndustries wrote:

  • Power pins should be on top/bottom edges of symbol
  • Package is missing silkscreen outlines apart from pin 1 indication
  • Assy refdes extends past assy outline

I will set the PR to Draft until I'm done with that.

@alex-fu27
Copy link
Author

Okay, I think I fixed the originial issues. I also changed the QFP32 package to a generic one that I generated using the wizard.

@alex-fu27 alex-fu27 marked this pull request as ready for review June 13, 2023 10:20
@alex-fu27
Copy link
Author

Bot!

@github-actions

This comment has been minimized.

@github-actions github-actions bot added the bot: warn At least one check resulted in warning label Jun 13, 2023
@alex-fu27
Copy link
Author

aaah haven't used Horizon for a while and forgot the parameter program

@alex-fu27
Copy link
Author

Bot!

@github-actions

This comment has been minimized.

@github-actions github-actions bot added bot: pass All checks passed and removed bot: warn At least one check resulted in warning labels Jun 13, 2023
@RX14
Copy link
Collaborator

RX14 commented Aug 12, 2023

Very sorry for the late review:

  • GND/VCC/AVCC text should horizontal, see "ATmega16/32" symbol
  • Refdes should be to the right of power pins, see the same smbol for reference

That's about all I can see, this is good.

@alex-fu27
Copy link
Author

Bot!

@github-actions
Copy link

This review is brought to you by the Horizon EDA Poolbot commit 33131f8.

Items in this PR

State Type Name Checks Version Filename
New Entity ATmega328P-AU ✔️ Pass 0 ✔️ entities/ic/mcu/microchip/ATmega328P-AU.json
New Package QFP32 ✔️ Pass 0 ✔️ packages/ic/smd/qfp/QFP32/package.json
New Part ATmega328P-AU ✔️ Pass 0 ✔️ parts/ic/mcu/microchip/ATmega328P-AU.json
New Symbol ATmega328P-AU ✔️ Pass 0 ✔️ symbols/ic/mcu/microchip/ATmega328P-AU.json
New Unit ATmega328P-AU ✔️ Pass 1 ❌ (>0) units/ic/mcu/microchip/ATmega328P-AU.json

Parts overview (excluding derived)

Bold items are from this PR

  • Part ATmega328P-AU
    • Package QFP32
      • Padstack SMD rectangular with rounded corners
    • Entity ATmega328P-AU
      • Unit ATmega328P-AU
        • Symbol ATmega328P-AU

Details

Parts

ATmega328P-AU

✔️ Checks passed

Attribute Value
MPN ATmega328P-AU
Value
Manufacturer Microchip (15 other parts)
Datasheet http://ww1.microchip.com/downloads/en/DeviceDoc/ATmega48A-PA-88A-PA-168A-PA-328-P-DS-DS40002061A.pdf
Description AVR 32KiB Flash 2KiB SRAM 2.5V/3.3V/5V 32-Pin TQFP
Tags avr mcu
Pad Gate Pin
1 Main PD3
2 Main PD4
3 Main GND
4 Main VCC
5 Main GND
6 Main VCC
7 Main PB6
8 Main PB7
9 Main PD5
10 Main PD6
11 Main PD7
12 Main PB0
13 Main PB1
14 Main PB2
15 Main PB3
16 Main PB4
17 Main PB5
18 Main AVCC
19 Main ADC6
20 Main AREF
21 Main GND
22 Main ADC7
23 Main PC0
24 Main PC1
25 Main PC2
26 Main PC3
27 Main PC4
28 Main PC5
29 Main PC6
30 Main PD0
31 Main PD1
32 Main PD2

Entities

ATmega328P-AU

✔️ Checks passed

Attribute Value
Manufacturer Microchip (15 other parts)
Prefix U
Tags avr mcu
Gate Suffix Swap group Unit
Main 0 ATmega328P-AU

Units

ATmega328P-AU

✔️ Checks passed

Attribute Value
Manufacturer Microchip (15 other parts)
Pin Direction Alternate names
ADC6 Input
ADC7 Input
AREF Input
AVCC Power Input
GND Power Input
PB0 Bidirectional ICP1 (NC), PCINT0 (NC), CLKO (NC)
PB1 Bidirectional PCINT1 (BiDi), OC1A (BiDi)
PB2 Bidirectional PCINT2 (BiDi), OC1B (BiDi)
PB3 Bidirectional MOSI (BiDi), PCINT3 (BiDi), OC2A (BiDi)
PB4 Bidirectional PCINT4 (BiDi), MISO (BiDi)
PB5 Bidirectional SCK (BiDi), PCINT5 (BiDi)
PB6 Bidirectional TOSC1 (PIn), PCINT6 (PIn), XTAL1 (PIn)
PB7 Bidirectional TOSC2 (BiDi), PCINT7 (BiDi), XTAL2 (BiDi)
PC0 Bidirectional ADC0 (BiDi), PCINT8 (BiDi)
PC1 Bidirectional ADC1 (BiDi), PCINT9 (BiDi)
PC2 Bidirectional ADC2 (BiDi), PCINT10 (BiDi)
PC3 Bidirectional ADC3 (BiDi), PCINT11 (BiDi)
PC4 Bidirectional PCINT12 (BiDi), ADC4 (BiDi), SDA (BiDi)
PC5 Bidirectional PCINT13 (BiDi), ADC5 (BiDi), SCL (BiDi)
PC6 Bidirectional RESET (BiDi), PCINT14 (BiDi)
PD0 Bidirectional RXD (BiDi), PCINT16 (BiDi)
PD1 Bidirectional TXD (BiDi), PCINT17 (BiDi)
PD2 Bidirectional INT0 (BiDi), PCINT18 (BiDi)
PD3 Bidirectional INT1 (BiDi), PCINT19 (BiDi), OC2B (BiDi)
PD4 Bidirectional T0 (BiDi), PCINT20 (BiDi), XCK (BiDi)
PD5 Bidirectional T1 (PIn), PCINT21 (PIn), OC0B (PIn)
PD6 Bidirectional AIN0 (BiDi), PCINT22 (BiDi), OC0A (BiDi)
PD7 Bidirectional PCINT23 (OC), AIN1 (OC)
VCC Power Input

Symbol: ATmega328P-AU

✔️ Checks passed

  • Is box symbol

Symbol

Packages

QFP32

Attribute Value
Manufacturer (124 other parts)
Tags generic ic qfp smd

✔️ Package checks passed

✔️ Clearance checks passed

Package

Parameters
Parameter Value
Courtyard expansion 000.250 mm
10.000mm 10.000mm
get-parameter [ courtyard_expansion ]
2 * +xy
set-polygon [ courtyard rectangle 0.000mm 0.000mm ]
Pads
Pad Padstack Pad width Pad height Corner radius
1 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
2 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
3 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
4 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
5 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
6 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
7 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
8 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
9 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
10 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
11 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
12 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
13 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
14 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
15 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
16 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
17 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
18 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
19 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
20 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
21 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
22 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
23 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
24 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
25 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
26 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
27 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
28 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
29 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
30 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
31 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
32 SMD rectangular with rounded corners 000.550 mm 001.600 mm 000.100 mm
3D views (no models)

Without model

Top Bottom
3D 3D
Pitch analysis
X Y Count
000.000 mm 000.800 mm 14
000.800 mm 000.000 mm 14
001.400 mm 001.400 mm 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: pass All checks passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants