Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify behaviour of mouse-wheel and mouse-drag image scrolling #353

Open
wants to merge 18 commits into
base: horos
Choose a base branch
from

Conversation

DD-P
Copy link
Contributor

@DD-P DD-P commented Jun 16, 2018

Hi.
I've re-done this PR from scratch, noting the comments in #347. Please let me know if the behaviour is now working appropriately for you.

@brizolara
Copy link
Contributor

Hi, David,

We couldn't have a 2nd look at your nice work yet. We are very thankful for your collaboration and we'll be reviewing soon, ok?

Best!

Tiago

@DD-P
Copy link
Contributor Author

DD-P commented Jun 28, 2018

Thanks Tiago. Yes, that's no problem. I could see that the 3.0-3.1.x series was being fine-tuned for release and expected this to be looked at later. You will want to be confident that changing the UX with this PR is correct, so not something to be rushed!

@brizolara
Copy link
Contributor

Tested and reviewed again. Working!

About not reversing scroll direction when Mac OS preferences for mouse scroll is set to Natural, I agree that it should reflect in Horos Preferences, disabling the reverse scroll option. I will open an issue, but it is no big deal...

Thanks again. As commented in other topic, the subject of informing credits of the changes in Horos is on the way...

Best,

Tiago

@UNNI65
Copy link

UNNI65 commented Mar 2, 2019

Hi all
I was trying to find a solution online for exactly the same issue of HOROS and hit on this forum. Thank you for bringing in this issue. Unfortunately it does not appear to be fixed.
What I did according to solution given above ...

  1. Set mouse scroll direction to Natural by checking the box in System Preferences MacOs
  2. Unchecked Reverse Scroll in Viewers Preferences in HOROS
    Tried the same example of scrolling though chest CT
    Mouse wheel working correctly , rolling towards us shows images that are inferior
    Mouse Drag not working correctly , if you drag it towards you the images go to upper sections of the chest rather than intended lower.
    This has caused annoyance to many of my students for whom I introduced HOROS for training.
    Would be very grateful if this issue is opened again to fix it.
    Many thanks in advance.
    UNNI65

@DD-P DD-P closed this Mar 2, 2019
@DD-P
Copy link
Contributor Author

DD-P commented Oct 10, 2019

Re-opening. Please consider for the 4.0 series now under development.

@DD-P DD-P reopened this Oct 10, 2019
@UNNI65
Copy link

UNNI65 commented Oct 10, 2019

Many thanks for opening it. Happy to see that it is opened again for a solution. I tried all advice given earlier in our forum and as they did not work, got a third party free application for Mac to fix it. Have been using this ever since. However I would be delighted to see a solution in our forum here.

@ddiazepam
Copy link

Hello. Is it possible to change mouse drag direction as an option in future? Coming from GE software is really confusing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants