Patch field order with avro #248
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 19, 2018 11:59
…ld a record with the right field order
I don't understand why using the row.toSeq.iterator fails in my environment I added the Unit test hortonworks-spark#247 showing that the problem doesn't exists in Travis See https://travis-ci.org/hortonworks-spark/shc/builds/368556158 => the Unit test fails without the patch, and succeed with. But stills fails in my environment ...
|
For the remaining problem with the order of the iterator, notice that I'm running Java8 and that your tests seem to be executed in Java7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix toBytes() to be not dependent on fields order in the incoming dataset to serialize in Avro.
This fix should in the mean time have better performance as we don't need to generate the Avro Schema from the dataset for each row (we only use the user supplied one)
How was this patch tested?
New Unit Test: "avro not dependent on schema field order"
This test as been submitted in #247 => it fails
With this patch => it succeeds