added brackets to logical expression to correctly distinguish between… #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or / and expression
lfrancke
added a commit
to lfrancke/spark-llap
that referenced
this pull request
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue : #273
What changes were proposed in this pull request?
As a user if we add multiple filters with "or" operator on spark dataframe it should be enclosed properly with correct brackets but in the current version of hwc multiple filters are not enclosed with proper brackets
for e.g.
df = df.fiter("condition1 or condition2")
df = df.filter("condition3 and condition4")
the resultant query created is as follows
(condition1) or (condition2) and (condition3) and (condition4)
ideally it should be as follows
((condition1) or (condition2)) and ((condition3) and (condition4))
How was this patch tested?
manual tests