This repository has been archived by the owner on Jun 12, 2021. It is now read-only.
WIP: Adds basic CRUD for categories #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm unable to confirm if categories are viewable/updatable -- I tried hitting the following endpoint: Is this expected? |
Just basic reads and some validation on the fields.
tejasa97
reviewed
Mar 28, 2020
| class Meta: | ||
| model = Item | ||
| fields = ["id", "name", "details"] | ||
| fields = ["id", "name", "details", "category"] |
There was a problem hiding this comment.
Me and @akshaytgithub were of the opinion that cateegory field isn't probably required now
There was a problem hiding this comment.
It's not serialized in a nested manner, just the category ID turns up:
/api/v1/items/
{
"count": 1,
"next": null,
"previous": null,
"results": [
{
"id": 3,
"name": "n95",
"details": "life saver!",
"category": 1
}
]
}Is that too much?
tejasa97
reviewed
Mar 28, 2020
| @@ -16,8 +26,11 @@ class Meta: | |||
| class Requirement(models.Model): | |||
| created = models.DateTimeField(auto_now_add=True) | |||
| user = models.OneToOneField(User, on_delete=models.CASCADE) | |||
There was a problem hiding this comment.
also the Requirement should be linked to the hospital_profile rather than the user, right?
There was a problem hiding this comment.
This an upstream thing: pls report in #14.
I'm doing only as much work as is required to link items and categories.
oyeb
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.