Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade larastan to v3 #200

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Upgrade larastan to v3 #200

wants to merge 2 commits into from

Conversation

captnCC
Copy link

@captnCC captnCC commented Nov 20, 2024

This pull request updates larastan to v3 and fixes the new analysis errors. v2 of larastan is still allowed as dependency to keep compatibility with projects that haven't upgraded to v3

Copy link
Collaborator

@bastien-phi bastien-phi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@@ -23,7 +23,7 @@
"opis/json-schema": "^2.3"
},
"require-dev": {
"larastan/larastan": "^2.8",
"larastan/larastan": "^2.8 || ^3.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the dependency is a dev dependency, there is no need to keep v2.

Suggested change
"larastan/larastan": "^2.8 || ^3.0",
"larastan/larastan": "^3.0",

@bastien-phi bastien-phi marked this pull request as draft January 17, 2025 08:27
@bastien-phi
Copy link
Collaborator

Thanks ! Please reopen when the change is done :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants