Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search projects #1325

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Fix search projects #1325

merged 1 commit into from
Mar 5, 2024

Conversation

Sujanadh
Copy link
Contributor

@Sujanadh Sujanadh commented Mar 5, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Issue

Describe this PR

This PR fixes the issue updating search filter query.

Screenshots

N/A

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@Sujanadh Sujanadh requested a review from spwoodcock March 5, 2024 08:54
@Sujanadh Sujanadh self-assigned this Mar 5, 2024
@Sujanadh Sujanadh marked this pull request as draft March 5, 2024 08:55
@github-actions github-actions bot added the backend Related to backend code label Mar 5, 2024
@Sujanadh
Copy link
Contributor Author

Sujanadh commented Mar 5, 2024

Minor fix for now. Thinking of updating all the queries using raw sql but it leads to changing other related functions, such as convert_to_app_project, into raw SQL, which might be complicated.
Or we can make this endpoint independent of the convert_to_app_project functions.

@spwoodcock
Copy link
Member

Awesome, thanks πŸ™
I'll get this into the beta release.

Agree we should refactor for raw SQL.
Very simple to change database driver to psycopg3 after that.

As for convert_to_app_project functions etc, I have been meaning to remove these for a while in favour of using Pydantic to handle it.

@spwoodcock
Copy link
Member

Merging this so it's included in the release I am now doing.

The refactor to raw SQL is a bigger task, so we can work on that after in another PR πŸ‘

@spwoodcock spwoodcock marked this pull request as ready for review March 5, 2024 17:20
@spwoodcock spwoodcock merged commit f3e7e24 into development Mar 5, 2024
5 checks passed
@spwoodcock spwoodcock deleted the fix/search-project branch March 5, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to search projects
2 participants