-
Notifications
You must be signed in to change notification settings - Fork 0
Configured template localization #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configured template localization #17
Conversation
@spwoodcock @dakotabenjamin hi! I'm hoping to get insight on the following error when deploying to test within the HOT's reusable pytest GH workflow:
|
Oh that might be my fault! Thanks for flagging! I am back tomorrow and will fix this - a minor tweak to the workflow. Until then you can just pin the specific version of gh-workflows. Change I wouldn't recommend ever pinning to |
@spwoodcock thanks for checking, I'll take this PR out of draft state then! Hope you're having a good weekend 👍🏼 |
I fixed the workflow - it was a minor update that broke the .env file generation. Going forward I would recommend pinning like this: jobs:
pytest:
uses: hotosm/gh-workflows/.github/workflows/[email protected]
with: otherwise breakage in the future is likely 👍 |
From the acceptance criteria in the Originating issue:
Template strings are added throughout the codebase where text content is present.
The make messages command is successfully integrated into Docker and can be run without errors.
Updated .po files are generated when make messages is run.
TODO: Will add documentation on how to correctly enable translation on a template string