Skip to content

Configured template localization #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

katporks
Copy link
Collaborator

From the acceptance criteria in the Originating issue:
Template strings are added throughout the codebase where text content is present.
The make messages command is successfully integrated into Docker and can be run without errors.
Updated .po files are generated when make messages is run.

TODO: Will add documentation on how to correctly enable translation on a template string

@katporks
Copy link
Collaborator Author

@spwoodcock @dakotabenjamin hi! I'm hoping to get insight on the following error when deploying to test within the HOT's reusable pytest GH workflow:

Downloading envsubst
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

100 2357k  100 2357k    0     0  4054k      0 --:--:-- --:--:-- --:--:-- 4054k
Substituting variables from  --> .env
/home/runner/work/_temp/b0fb54d6-9df1-49ff-ac58-527e6fa22141.sh: line 8: : No such file or directory
Error: Process completed with exit code 1.

@spwoodcock
Copy link
Member

Oh that might be my fault! Thanks for flagging!

I am back tomorrow and will fix this - a minor tweak to the workflow.

Until then you can just pin the specific version of gh-workflows. Change @main to be a specific tag like @1.4.3.

I wouldn't recommend ever pinning to main as the latest version will be pulled & may cause breaking changes in the future 👍

@katporks
Copy link
Collaborator Author

Oh that might be my fault! Thanks for flagging!

I am back tomorrow and will fix this - a minor tweak to the workflow.

Until then you can just pin the specific version of gh-workflows. Change @main to be a specific tag like @1.4.3.

I wouldn't recommend ever pinning to main as the latest version will be pulled & may cause breaking changes in the future 👍

@spwoodcock thanks for checking, I'll take this PR out of draft state then! Hope you're having a good weekend 👍🏼

@katporks katporks marked this pull request as ready for review February 19, 2024 10:38
@spwoodcock
Copy link
Member

I fixed the workflow - it was a minor update that broke the .env file generation.

Going forward I would recommend pinning like this:

jobs:
  pytest:
    uses: hotosm/gh-workflows/.github/workflows/[email protected]
    with:

otherwise breakage in the future is likely 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants