Implemented: time zone selector displays user's current time (dxp-221) #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymaheshwari1
requested changes
Feb 2, 2024
src/locales/en.json
Outdated
| @@ -111,6 +111,7 @@ | |||
| "In 15 minutes": "In 15 minutes", | |||
| "In 5 minutes": "In 5 minutes", | |||
| "In an hour": "In an hour", | |||
| "India Standard Time(Asia/Culcutta)": "India Standard Time(Asia/Culcutta)", | |||
There was a problem hiding this comment.
No need to add this in locale
src/views/Settings.vue
Outdated
| <ion-label> {{ userProfile && userProfile.userTimeZone ? userProfile.userTimeZone : '-' }} </ion-label> | ||
| <ion-button @click="changeTimeZone()" slot="end" fill="outline" color="dark">{{ $t("Change") }}</ion-button> | ||
| </ion-item> | ||
| <ion-item lines="none"> |
src/views/Settings.vue
Outdated
| <ion-button @click="changeTimeZone()" slot="end" fill="outline" color="dark">{{ $t("Change") }}</ion-button> | ||
| </ion-item> | ||
| <ion-item lines="none"> | ||
| <ion-label>Browse time zone</ion-label> |
There was a problem hiding this comment.
Add translation for static text
Suggested change
| <ion-label>Browse time zone</ion-label> | |
| <ion-label>Browser time zone</ion-label> |
src/views/Settings.vue
Outdated
| return this.userProfile?.userTimeZone || this.defaultTimeZone | ||
| }, | ||
| defaultTimeZone(){ | ||
| return DateTime.local().setZone('Asia/Kolkata').toFormat('hh:mm a ZZZZ'); |
There was a problem hiding this comment.
We don't need to hardcode the zone, the zone should be identified from the browser's timeZone.
src/views/TimezoneModal.vue
Outdated
| </ion-item> | ||
| </ion-radio-group> | ||
| </ion-list> | ||
| <div> |
There was a problem hiding this comment.
I think there is no need for an extra div.
shanmukhdutt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #
Short Description and Why It's Useful
Screenshots of Visual Changes
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance