Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add working-directory field so you can release a sub-dir Rust project #4

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

Snoupix
Copy link
Contributor

@Snoupix Snoupix commented Nov 18, 2024

Follow up of the closed PR #2.

@autarch
Copy link
Member

autarch commented Nov 18, 2024

Ok, this time I was able to push. I think it was definitely because the forked repo's PR was based on the v0 branch.

@Snoupix
Copy link
Contributor Author

Snoupix commented Nov 18, 2024

Perfect, thank you for your time !
To me both of the PRs were based on the v0 branch but this time I created a branch for the PR. I don't know.

@autarch
Copy link
Member

autarch commented Nov 18, 2024

Perfect, thank you for your time ! To me both of the PRs were based on the v0 branch but this time I created a branch for the PR. I don't know.

If you use the default branch in your fork as the basis for the PR, GitHub doesn't let me push to it. I think that makes sense, though I don't think it's well-documented.

@Snoupix
Copy link
Contributor Author

Snoupix commented Nov 18, 2024

Hum yes, it makes sense. Well, we learned something :)

When this is set, all release actions are performed from this directory. This allows releasing
projects in a sub-directory of the main repo.
@autarch autarch force-pushed the feat-working_dir branch 4 times, most recently from 4015d3a to 403a694 Compare November 18, 2024 19:13
@autarch autarch merged commit 2724b35 into houseabsolute:v0 Nov 18, 2024
9 checks passed
@autarch
Copy link
Member

autarch commented Nov 18, 2024

Thanks for working through this with me.

@Snoupix Snoupix deleted the feat-working_dir branch November 22, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants