Skip to content

Potential fixes for 5 code quality findings #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajm19826 merged 5 commits into from
Mar 27, 2026
Merged

Potential fixes for 5 code quality findings #114

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e40820f
Apply suggested fix to math-page.html from Copilot Autofix
ajm19826 Mar 27, 2026
b6ddd0a
Apply suggested fix to math-page.html from Copilot Autofix
ajm19826 Mar 27, 2026
929d4da
Apply suggested fix to math-page.html from Copilot Autofix
ajm19826 Mar 27, 2026
4218859
Apply suggested fix to math-page.html from Copilot Autofix
ajm19826 Mar 27, 2026
7318c83
Apply suggested fix to math-page.html from Copilot Autofix
ajm19826 Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions math-page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@
<div class="content-wrapper">
<div class="main-content">
<h1>K–12 Math Lessons | CoolMathTime</h1>
<div class="warp-buttons">
<div class="grade-navigation-buttons">
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While changing the class name to grade-navigation-buttons improves semantic clarity, the refactoring is incomplete. The surrounding elements still use the old 'warp' terminology, such as the h2 text 'Warp to Grade:' (line 216) and the ID warp-buttons-container (line 217). This creates an inconsistency that could be confusing for future maintenance. For better consistency, consider renaming these as well. Note that changing the ID will also require an update to the corresponding JavaScript.

Copy link
Copy Markdown
Member

@khalid-ameri khalid-ameri Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rename

<h2>Warp to Grade:</h2>
<div id="warp-buttons-container"></div>
</div>
Expand Down Expand Up @@ -449,7 +449,7 @@ <h2 id="lessons-title">Old CoolMathTime lessons</h2>
<div class="lesson-card"><h3>Multiplication & Division</h3><a href="https://houselearning.org/home/math/bin/multiplyanddivide.html" target="_blank" rel="noopener">Start Lesson</a></div>
<div class="lesson-card"><h3>Fractions & Decimals</h3><a href="https://houselearning.org/home/math/bin/fractionanddecimals.html" target="_blank" rel="noopener">Start Lesson</a></div>
<div class="lesson-card"><h3>Basic Geometry</h3><a href="https://houselearning.org/home/math/bin/basicgeometry.html" target="_blank" rel="noopener">Start Lesson</a></div>
<div class="lesson-card"><h3>Measurement & Time</h3><a href="https://houselearning.org/bin/home/math/measurementandtime.html" target="_blank" rel="noopener">Start Lesson</a></div>
<div class="lesson-card"><h3>Measurement & Time</h3><a href="https://houselearning.org/home/math/bin/measurementandtime.html" target="_blank" rel="noopener">Start Lesson</a></div>
<div class="lesson-card"><h3>Money Math</h3><a href="https://houselearning.org/home/math/bin/moneysort.html" target="_blank" rel="noopener">Start Lesson</a></div>
<div class="lesson-card"><h3>Algebra Basics</h3><a href="https://houselearning.org/home/math/bin/basicalgebra.html" target="_blank" rel="noopener">Start Lesson</a></div>
<div class="lesson-card"><h3>Graphing & Coordinates</h3><a href="https://houselearning.org/home/math/bin/coords.html" target="_blank" rel="noopener">Start Lesson</a></div>
Expand All @@ -460,7 +460,7 @@ <h2 id="lessons-title">Old CoolMathTime lessons</h2>
<div class="lesson-card"><h3>Integers & Rational Numbers</h3><a href="https://houselearning.org/home/math/bin/ratios.html" target="_blank" rel="noopener">Start Lesson</a></div>
<div class="lesson-card"><h3>Ratios & Proportions</h3><a href="https://houselearning.org/home/math/bin/proportions.html" target="_blank" rel="noopener">Start Lesson</a></div>
<div class="lesson-card"><h3>Angles & Shapes</h3><a href="https://houselearning.org/home/math/bin/angles.html" target="_blank" rel="noopener">Start Lesson</a></div>
<div class="lesson-card"><h3>Perimeter & Area</h3><a href="https://houselearning.org/home/math/bin/perimiter.html" target="_blank" rel="noopener">Start Lesson</a></div>
<div class="lesson-card"><h3>Perimeter & Area</h3><a href="https://houselearning.org/home/math/bin/perimeter.html" target="_blank" rel="noopener">Start Lesson</a></div>
<div class="lesson-card"><h3>Volume & Surface Area</h3><a href="https://houselearning.org/home/math/bin/volumesurface.html" target="_blank" rel="noopener">Start Lesson</a></div>
<div class="lesson-card"><h3>Graphing Equations</h3><a href="https://houselearning.org/home/math/bin/graphequations.html" target="_blank" rel="noopener">Start Lesson</a></div>
<div class="lesson-card"><h3>Linear Functions</h3><a href="https://houselearning.org/home/math/bin/linearfunctions.html" target="_blank" rel="noopener">Start Lesson</a></div>
Expand All @@ -478,7 +478,7 @@ <h3>Math Maze</h3>
</div>

<div class="game-card">
<img src="https://houselearning.org/android-chrome-512x512.png" alt="">
<img src="https://houselearning.org/android-chrome-512x512.png" alt="Game in development placeholder">
<h3>GAME IN DEVELOPMENT</h3>
<a href="#" target="_blank" rel="noopener">WORTH THE WAIT!</a>
</div>
Expand Down Expand Up @@ -521,7 +521,7 @@ <h3>Graph Genius</h3>

<div class="game-card">
<!-- placeholder image & link for algebruh since original was incomplete -->
<img src="https://houselearning.org/android-chrome-512x512.png" alt="">
<img src="https://houselearning.org/android-chrome-512x512.png" alt="Game in development placeholder">
<h3>GAME IN DEVELOPMENT</h3>
<a href="#" target="_blank" rel="noopener">WORTH THE WAIT!</a>
</div>
Expand Down
Loading