-
-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recreate time in tray images #1502
Merged
hovancik
merged 13 commits into
hovancik:trunk
from
Wikiwix:recreate-time-in-tray-images
Oct 31, 2024
Merged
Recreate time in tray images #1502
hovancik
merged 13 commits into
hovancik:trunk
from
Wikiwix:recreate-time-in-tray-images
Oct 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This matches the tooltip more closely
The font size is now based on the baseImage's height relatively, instead of a hardcoded value.
Wikiwix
force-pushed
the
recreate-time-in-tray-images
branch
from
October 28, 2024 05:55
696ca55
to
2e2a758
Compare
hovancik
reviewed
Oct 31, 2024
This reverts commit f17e3dc.
hovancik
approved these changes
Oct 31, 2024
Merged, feel free to create new PR with changes to round/ceil but we need to look into how to make it consistent |
This was referenced Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: closes #1478
Requirements
node
version specified inpackage.json
was used (ie using nvm).npm install --no-save
).→ This is not true for the icon script: Since it is not run on the user's side I considered this okay
npm run lint
reports no offenses.npm run test
is error-free.Description of the Change
Starting from #1501 I tweaked the design and creation script of the tray icons with number in it. In detail I made the following changes (following the commit order)
Fix image names for mac
Remove old link
Better icons for "Time in tray"
Add save space around the text in the tray icons
Improve logging and code structure slightly
Improve glanceability of logging
Display more accurate remaining time in tray
Adapt fontColor to match icon colour
Switch to more visually matching Noto Sans Regular
Tweak font size
The font size is now based on the baseImage's height relatively, instead of a hardcoded value.
Add the newly rendered icons
Add Wikiwix as a contributor
Verification Process
Run the dev version with over time with the new icons
Other information
There are still two improvements I was thinking about, but the PR is already large enough as it stands…