Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate time in tray images #1502

Merged
merged 13 commits into from
Oct 31, 2024

Conversation

Wikiwix
Copy link
Contributor

@Wikiwix Wikiwix commented Oct 28, 2024

Issue: closes #1478

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • issue was opened to discuss proposed changes before starting implementation. It is important do discuss changes before implementing them (Why should we add it? How should it work? How should it look? Where will it be? ...).
  • during development, node version specified in package.json was used (ie using nvm).
  • package versions and package-lock.json were not changed (npm install --no-save).
  • app version number was not changed.
  • all new code has tests to ensure against regressions.
    → This is not true for the icon script: Since it is not run on the user's side I considered this okay
  • npm run lint reports no offenses.
  • npm run test is error-free.
  • README and CHANGELOG were updated accordingly.
  • after PR is approved, all commits in it are squashed

Description of the Change

Starting from #1501 I tweaked the design and creation script of the tray icons with number in it. In detail I made the following changes (following the commit order)

Fix image names for mac

Remove old link

Better icons for "Time in tray"

Add save space around the text in the tray icons

Improve logging and code structure slightly

Improve glanceability of logging

Display more accurate remaining time in tray

  • This matches the tooltip's information more closely

Adapt fontColor to match icon colour

Switch to more visually matching Noto Sans Regular

Tweak font size

The font size is now based on the baseImage's height relatively, instead of a hardcoded value.

Add the newly rendered icons

Add Wikiwix as a contributor

Verification Process

Run the dev version with over time with the new icons

Other information

There are still two improvements I was thinking about, but the PR is already large enough as it stands…

  • Make the paused icons more inline with the new numbered icons
  • For the non-mac monochrome icons tweak the colours, so it matches the native colours on Windows 11 (since this is, as far as I can see the only reasonable target to optimise for (due to Mac having different icons and Linux being as diverse as it is))
  • For these to changes I would switch to using the svg files as the source in the script (makes colour changes easy)

@Wikiwix Wikiwix force-pushed the recreate-time-in-tray-images branch from 696ca55 to 2e2a758 Compare October 28, 2024 05:55
@Wikiwix Wikiwix marked this pull request as ready for review October 28, 2024 05:58
app/utils/utils.js Outdated Show resolved Hide resolved
@hovancik hovancik merged commit a790f12 into hovancik:trunk Oct 31, 2024
3 checks passed
@hovancik
Copy link
Owner

Merged, feel free to create new PR with changes to round/ceil but we need to look into how to make it consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: More legible remaining time in tray icon
2 participants