ctrl + [ support for exiting insert mode #536
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalabhc
reviewed
Nov 4, 2019
bundles/vi/insert_map.moon
Outdated
| @@ -33,6 +33,12 @@ insert_map = { | |||
| state.change_mode editor, 'command' | |||
| editor.cursor.column = math.max 1, editor.cursor.column - 1 | |||
|
|
|||
| 'ctrl_[': (editor) -> | |||
| state.insert_edit = get_edit editor | |||
There was a problem hiding this comment.
Can you please extract the code into a exit_insert_mode function at the top next to get_edit?
There was a problem hiding this comment.
I've refactored the code per your request. Let me know if there's anything else I can do!
shalabhc
reviewed
Nov 7, 2019
bundles/vi/insert_map.moon
Outdated
| state.change_mode editor, 'command' | ||
| editor.cursor.column = math.max 1, editor.cursor.column - 1 | ||
|
|
||
| escape: (editor) -> exit_insert_mode editor |
There was a problem hiding this comment.
I think this can just be written as
escape: exit_insert_mode
Same for next line.
Otherwise looks good to me!
There was a problem hiding this comment.
I've found that the ctrl + [ doesn't work when writing python code at least, there's probably something overriding the key combo for that syntax, I'll investigate further at some point.
There was a problem hiding this comment.
Do you still want to merge this then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for 'ctrl + [' to exit insert mode in the vi bundle.
Just duplicated the 'escape' portion of the insert_map.moon and swapped in the 'ctrl + ['