Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude local path prefixes from being cached #34

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

jjhursey
Copy link
Contributor

  • Feature enabled by default, but can be disabled by setting the
    envar SPINDLE_DISABLE_EXCLUDE=1

 * Feature enabled by default, but can be disabled by setting the
   envar `SPINDLE_DISABLE_EXCLUDE=1`

Signed-off-by: Joshua Hursey <[email protected]>
@jjhursey
Copy link
Contributor Author

This one I would like to get some feedback on. I don't love the explicit list of file system mounts. Something better might be to check the file system associated with the path to exclude the local file system mounts. I wasn't sure how to do that portably / efficiently.
I'm mostly posting this for comment/discussion.

@mplegendre
Copy link
Member

I like the feature, but agree about needing a better implementation. Some of those hardcoded paths are NFS on our linux clusters.

The last release added an internal capability to parse the system's mount points in the server:
https://github.com/hpc/Spindle/blob/devel/src/server/auditserver/parse_mounts.cc

We're currently using this to correct the device field in stat calls when different nodes have different device major/minor ids. But we could also parse a prefix list out of this that identifies local filesystems. Then have servers respond to clients with a message to self-read if it sees something prefixed as local.

We'd need a proper list of what filesystem types are remote vs local.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants