Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug at mha, MaskGenerator; improve ckpt_utils.py #609

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

flymin
Copy link

@flymin flymin commented Jul 16, 2024

  1. fix bug in mha when mask=None.
  2. fix bug in MaskGenerator. If the video is short, any type of mask has chances to mask all.
  3. use logger in load_checkpoint.

@flymin
Copy link
Author

flymin commented Jul 16, 2024

Regarding 1, another solution is to change

q = self.q_linear(x).view(1, -1, self.num_heads, self.head_dim)

to

q = self.q_linear(x).view(B, -1, self.num_heads, self.head_dim)

if mask is None. Current implementation on the main branch assumes mask is never to be None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants