Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filters to filter JMs #784

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Added filters to filter JMs #784

wants to merge 8 commits into from

Conversation

ydahal1
Copy link
Collaborator

@ydahal1 ydahal1 commented Jun 10, 2024

Description

Please provide a summary of the changes made and the issue it resolves. Include relevant context and any dependencies required for this change.

Fixes # (issue)

Developer's Checklist

Please select at least one

  • Bug fix (non-breaking change that resolves an issue)
  • Breaking change (enhancement, fix, or feature that alters existing functionality)
  • New feature (non-breaking change that adds functionality)
  • Vulnerability fix (package updates or CodeQL adjustments to enhance code security)
  • Documentation update (addition or update of documentation or helper text)
  • Other change (please explain in the comment section)

Code Quality ( All must be selected )

  • I have commented on my code, especially in complex areas
  • I have resolved any conflicts with the target branch
  • My changes do not generate new warnings
  • I have checked my code for any misspellings
  • I have ensured my code does not duplicate existing code unnecessarily

Documentation

  • No documentation changes were required
  • I have made corresponding changes to the documentation

Security

  • I have confirmed that all security checks (e.g., CodeQL) have passed
  • No user input validation was required for this change
  • All user inputs have appropriate validation, including reasonable character limits

UX

  • This change does not involve any updates to UX elements
  • Refreshing related pages results in a functional and logical state
  • Appropriate error messages are displayed when necessary

Testing

  • Existing unit tests pass locally with my changes
  • No new unit tests were necessary for my changes
  • I have added new unit tests for my changes

Reviewer Checklist

  • I have successfully pulled the branch into my local environment, initiated the project, and verified that all the checked items above have passed

Copy link
Collaborator

@FancMa01 FancMa01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I hide filters, there is no indication that a filter is active.

Also, when I re-show the filters, it doesn't indicate that my previous filters are applied.

  1. Applied filter

image

  1. Hide Filters (no indication of filtering applied)
    image

  2. Re-show filters (filters that are applied are not displaying)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants