HPCC4J-639 Add concurrent connection startup limit #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jira Issue: https://hpccsystems.atlassian.net/browse/HPCC4J-639 Jirabot Action Result: |
rpastrana
requested changes
Sep 18, 2024
| @@ -622,12 +661,14 @@ private static Options getReadTestOptions() | |||
| options.addOption("pass", true, "Specifies the password used to connect. Defaults to null."); | |||
| options.addOption("num_threads", true, "Specifies the number of parallel to use to perform operations."); | |||
| options.addOption("access_expiry_seconds", true, "Access token expiration seconds."); | |||
| options.addOption("initial_read_size", true, "The size of the initial read request in KB sent to the rowservice."); | |||
There was a problem hiding this comment.
perhaps a comment on why users would be interested in setting this value
| while (fileReader.hasNext()) | ||
| { | ||
| HPCCRecord record = fileReader.next(); | ||
| context.getCurrentOperation().recordsRead.incrementAndGet(); | ||
| recCount++; |
jpmcmu
changed the title
rpastrana
reviewed
Sep 24, 2024
| try | ||
| { | ||
| Thread.sleep(1); | ||
| } catch (InterruptedException e) {} // We don't care about waking early |
There was a problem hiding this comment.
minor format issue, missing new line
rpastrana
reviewed
Sep 24, 2024
| @@ -857,6 +923,7 @@ public void startBlockingFetchRequest(List<Long> fetchOffsets) throws Exception | |||
| { | |||
| finishFetch(); | |||
| } | |||
|
|
|||
rpastrana
approved these changes
Sep 24, 2024
- Added a limit to the number of connections that can be started simultaneously - Reduced the size of the initial read request - Exposed parameters in FileUtility Signed-off-by: James McMullan [email protected]
|
Jirabot Action Result: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James McMullan [email protected]
Type of change:
Checklist:
Testing: