BC-8348 - Implement Sharing and Copying of Room Boards #3452
Conversation
uidp
changed the title
src/locales/es.ts
Outdated
| @@ -597,6 +597,10 @@ export default { | |||
| "components.molecules.import.columnBoard.options.selectCourse.infoText": | |||
| "Seleccione el curso al que desea importar el tablero.", | |||
| "components.molecules.import.courses.label": "Curso", | |||
| "components.molecules.import.columnBoard.options.selectRoom": | |||
| "Elija habitación", | |||
There was a problem hiding this comment.
We decided on going with "sala" instead of "habitación"
There was a problem hiding this comment.
Ok, can you help with the right translation? What would it be then - "Elija sala"?
| role="menuitem" | ||
| data-testid="room-action-delete" | ||
| :aria-label=" | ||
| $t('pages.roomDetails.ariaLabels.menu.action.delete') | ||
| " | ||
| @click="onDelete" | ||
| @click="deleteBoard" |
There was a problem hiding this comment.
A while ago we decided that "on" + eventName is our convention to name event handlers
There was a problem hiding this comment.
Ok, but it reads much better this way IMHO (like "At click: delete board"). And what about methods that are called from event handlers + from other methods? Should we wrap these methods in on<method> functions so they can be called as event handlers? Example would be createBoard which is called from fabItemClickHandler. Is there anything we gain in terms of readability when we prefix the event handlers with on?
uidp
changed the title
|
Short Description
We have to implement sharing and copying of boards that are associated to rooms. Currently this is only possible for boards that belong to courses. In order to do this we have to extend the ShareTokenModule and BoardModule.
Links to Ticket and related Pull-Requests
BC-8348
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging