Skip to content

N21-2320 Share links for board cards#3497

Merged
MarvinOehlerkingCap merged 9 commits intomainfrom
N21-2320-link-board-card
Jan 22, 2025
Merged

N21-2320 Share links for board cards#3497
MarvinOehlerkingCap merged 9 commits intomainfrom
N21-2320-link-board-card

Conversation

@MarvinOehlerkingCap
Copy link
Copy Markdown
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented Jan 15, 2025

Short Description

Links to Ticket and related Pull-Requests

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

# Conflicts:
#	src/modules/feature/board/card/CardHost.unit.ts
#	src/modules/feature/board/card/CardHost.vue
#	src/modules/ui/board/index.ts
Copy link
Copy Markdown
Contributor

@GordonNicholasCap GordonNicholasCap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only a small change needed

Comment thread src/modules/util/board/shareBoardLink.composable.unit.ts Outdated
MarvinOehlerkingCap and others added 3 commits January 21, 2025 13:09
Co-authored-by: Gordon Nicholas <160246213+GordonNicholasCap@users.noreply.github.com>
# Conflicts:
#	src/modules/util/board/index.ts
@sonarqubecloud
Copy link
Copy Markdown

@MarvinOehlerkingCap MarvinOehlerkingCap merged commit d38bdbc into main Jan 22, 2025
@MarvinOehlerkingCap MarvinOehlerkingCap deleted the N21-2320-link-board-card branch January 22, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants