Skip to content

BC-10367 Replace request-promise by axios#3732

Merged
dyedwiper merged 26 commits into
mainfrom
BC-10367-request-promise
Dec 18, 2025
Merged

BC-10367 Replace request-promise by axios#3732
dyedwiper merged 26 commits into
mainfrom
BC-10367-request-promise

Conversation

@dyedwiper
Copy link
Copy Markdown
Contributor

@dyedwiper dyedwiper commented Dec 15, 2025

Description

Links to Tickets or other pull requests

BC-10367

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Comment thread controllers/ghost.js Fixed
dyedwiper and others added 4 commits December 15, 2025 11:42
Comment thread helpers/apiHelper.js Fixed
Comment thread helpers/apiHelper.js Fixed
@dyedwiper dyedwiper marked this pull request as draft December 15, 2025 14:55
Comment thread helpers/apiHelper.js Fixed
Comment thread helpers/apiHelper.js Fixed
Comment thread helpers/apiHelper.js Fixed
@dyedwiper dyedwiper marked this pull request as ready for review December 18, 2025 09:50
@sonarqubecloud
Copy link
Copy Markdown

Comment thread helpers/apiHelper.js
const mappedError = mapError(err);

throw mappedError;
});
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dyedwiper dyedwiper merged commit 3a76c33 into main Dec 18, 2025
221 of 231 checks passed
@dyedwiper dyedwiper deleted the BC-10367-request-promise branch December 18, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants