BC - 5654 Remove usage of @shared/domain/index.ts #4563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfganggreschus
added
the
WIP
…cloud/schulcloud-server into BC-5654-remove-usage-of-index
wolfganggreschus
removed
the
WIP
EzzatOmar
requested changes
Nov 28, 2023
EzzatOmar
approved these changes
Nov 29, 2023
…cloud/schulcloud-server into BC-5654-remove-usage-of-index
|
Kudos, SonarCloud Quality Gate passed! |
bergatco
pushed a commit
that referenced
this pull request
Dec 6, 2023
* removed export * from './domainobject' * corrected apps/server/src/modules/authentication/strategy/ldap.strategy.ts * removed: export * from './types'; * removed: export * from './service' * removed: export * from './interface' * removed: export * from './interface'; * removed: export * from './entity'; * removed index in shared/domain --------- Co-authored-by: Wolfgang Greschus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To avoid js dependency cycles we should not import from @shared/domain and avoiding it to do it in future.
Links to Tickets or other pull requests
BC-5654
Changes
all re-exports from @shared/domain/index.ts should be removed
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.