Merged
Conversation
1 task
mamutmk5
requested changes
Aug 23, 2024
mamutmk5
requested changes
Aug 27, 2024
Comment on lines
+16
to
+19
| state: "{{ 'present' if | ||
| WITH_BRANCH_MONGO_DB_MANAGEMENT is defined and WITH_BRANCH_MONGO_DB_MANAGEMENT|bool and | ||
| WITH_COMMON_CARTRIDGE is defined and WITH_COMMON_CARTRIDGE|bool | ||
| else 'absent'}}" |
Member
There was a problem hiding this comment.
Intressting that his works, is your intenntion right to place the condition for WITH_COMMON_CARTRIDGE there?
Contributor
Author
There was a problem hiding this comment.
It think so. Only if common cartridge is enabled we need the External Secret for it otherwise it can be removed. Do you see a problem there that I am overlooking?
Member
There was a problem hiding this comment.
It was only the differenc where WITH_COMMON_CARTRIDGE is defined and WITH_COMMON_CARTRIDGE|bool is place what me wonder.
mamutmk5
approved these changes
Aug 29, 2024
simoncolincap
approved these changes
Sep 19, 2024
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of the migration to IONOS MongoDB.
Implements a branch specific Secret (DB name in connection String is different for each namespace) via ExternalSecrets for:
Disable
bypassDocumentValidationin the seeding (bypassing would require admin permissions for the IONOS MongoDB that we don't want to add).Should be merged before it's counterpart in dof_app_deploy (changes are inactive until enabled there).
Links to Tickets or other pull requests
hpi-schul-cloud/dof_app_deploy#938
OPS-6706
BC-7793
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.