-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EW-1055: Work on Dataport TSP review comments: Folder structure #5358
base: main
Are you sure you want to change the base?
Conversation
…d the parent config added and modified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be named 'sync.config.ts'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Quality Gate passedIssues Measures |
Description
In the Dataport TSP code review, the TSP related code were reviewed. In this ticket the TODOs related to folder structure and config file have to be solved. The to-dos include the following:
Folder structure: move tsp folder into strategy folder
Create a config file in the sync module and extend the tsp config file
Changes
moved tsp into strategy folder
created an upper level interface to contain the fields of the interface
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:server
was executed in vue frontend and changes were tested and put in a PR with the same branch name.