Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EW-1055: Work on Dataport TSP review comments: Folder structure #5358

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

HKayed
Copy link
Contributor

@HKayed HKayed commented Nov 27, 2024

Description

In the Dataport TSP code review, the TSP related code were reviewed. In this ticket the TODOs related to folder structure and config file have to be solved. The to-dos include the following:

Folder structure: move tsp folder into strategy folder
Create a config file in the sync module and extend the tsp config file

Changes

moved tsp into strategy folder
created an upper level interface to contain the fields of the interface

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@HKayed HKayed reopened this Nov 28, 2024
Copy link
Contributor

@SimoneRadtke-Cap SimoneRadtke-Cap Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be named 'sync.config.ts'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link

sonarcloud bot commented Nov 29, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants