Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-8556 implement request logging in nestjs #5401

Merged
merged 16 commits into from
Dec 20, 2024
Merged

BC-8556 implement request logging in nestjs #5401

merged 16 commits into from
Dec 20, 2024

Conversation

Loki-Afro
Copy link
Member

@Loki-Afro Loki-Afro commented Dec 16, 2024

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-8556

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

@Loki-Afro Loki-Afro changed the title BC-8559 implement request logging in nestjs BC-8556 implement request logging in nestjs Dec 16, 2024
bischofmax and others added 6 commits December 16, 2024 09:43
* add roomadmin and roomowner roles

* remove room_delete permission from roomeditor

* creating room memberships is now an operation seperate from adding users.
** creating a room memberships adds a user as owner
** adding a user fails if no membership exists yet

* fix room membership rule to use room role to check permissions

* ensure that room owners can not be removed from a room

---------

Co-authored-by: Thomas Feldtkeller <[email protected]>
@CeEv
Copy link
Contributor

CeEv commented Dec 17, 2024

The middleware want to have spec.ts. @Loki-Afro

@Loki-Afro Loki-Afro merged commit cb1f7a6 into main Dec 20, 2024
76 checks passed
@Loki-Afro Loki-Afro deleted the bc-8556 branch December 20, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants