BC-8635 - fix task permission #5417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the task had no course or lesson it was possible for another teacher to gain permission to the task
…schul-cloud/schulcloud-server into BC-8635-fix-task-permission
|
EzzatOmar
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
you can remove the comment in line 45:
// TODO why parent permission has OR cond?
HKayed
pushed a commit
that referenced
this pull request
Jan 30, 2025
when the task had no course or lesson it was possible for another teacher to gain permission to the task
psachmann
pushed a commit
that referenced
this pull request
Feb 11, 2025
when the task had no course or lesson it was possible for another teacher to gain permission to the task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when the task had no course or lesson
it was possible for another teacher
to gain permission to the task
Links to Tickets or other pull requests
BC-8635
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.