EW-1071 Common Cartridge microservice creates boards during import #5435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psachmann
changed the title
Fshmit
reviewed
Jan 22, 2025
apps/server/src/infra/boards-client/boards-client.adapter.spec.ts
Outdated
Show resolved
Hide resolved
Fshmit
reviewed
Jan 22, 2025
apps/server/src/infra/boards-client/boards-client.adapter.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Fshmit <[email protected]>
Co-authored-by: Fshmit <[email protected]>
|
@psachmann Implementation works well ✅. |
| @@ -235,4 +235,24 @@ describe('CourseService', () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('create', () => { | |||
There was a problem hiding this comment.
The test exists already above.
SimoneRadtke-Cap
approved these changes
Jan 23, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Common Cartridge microservice can now add boards with titles during import to a course. Additionally, the boards-client module was updated and moved to infra. OpenAPI client generation was aligned with the new way and npm script was added for easy use.
Links to Tickets or other pull requests
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.