Skip to content

BC-8650 - Add feature flag for permissions change in rooms #5447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 21, 2025
Merged

BC-8650 - Add feature flag for permissions change in rooms #5447

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
306d351
add feature flag for room permissions
NFriedo Jan 20, 2025
75cd986
Merge branch 'main' into BC-8650-room-permissions-flag
NFriedo Jan 20, 2025
923aa3b
review comment: set room feature to default true in default schema, r…
NFriedo Jan 20, 2025
2f422ed
Merge branch 'main' into BC-8650-room-permissions-flag
NFriedo Jan 21, 2025
061388f
Merge branch 'main' into BC-8650-room-permissions-flag
NFriedo Jan 21, 2025
982b0ef
fix server api test
NFriedo Jan 21, 2025
ccc5718
Merge branch 'main' into BC-8650-room-permissions-flag
NFriedo Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/server/src/modules/server/api/dto/config.response.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,9 @@ export class ConfigResponse {
@ApiProperty()
FEATURE_ROOMS_ENABLED: boolean;

@ApiProperty()
FEATURE_ROOMS_CHANGE_PERMISSIONS_ENABLED: boolean;

@ApiProperty()
FEATURE_EXTERNAL_SYSTEM_LOGOUT_ENABLED: boolean;

Expand Down Expand Up @@ -300,6 +303,7 @@ export class ConfigResponse {
this.FEATURE_SCHULCONNEX_MEDIA_LICENSE_ENABLED = config.FEATURE_SCHULCONNEX_MEDIA_LICENSE_ENABLED;
this.FEATURE_AI_TUTOR_ENABLED = config.FEATURE_AI_TUTOR_ENABLED;
this.FEATURE_ROOMS_ENABLED = config.FEATURE_ROOMS_ENABLED;
this.FEATURE_ROOMS_CHANGE_PERMISSIONS_ENABLED = config.FEATURE_ROOMS_CHANGE_PERMISSIONS_ENABLED;
this.FEATURE_EXTERNAL_SYSTEM_LOGOUT_ENABLED = config.FEATURE_EXTERNAL_SYSTEM_LOGOUT_ENABLED;
}
}
2 changes: 2 additions & 0 deletions apps/server/src/modules/server/server.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ export interface ServerConfig
BOARD_COLLABORATION_URI: string;
FEATURE_AI_TUTOR_ENABLED: boolean;
FEATURE_ROOMS_ENABLED: boolean;
FEATURE_ROOMS_CHANGE_PERMISSIONS_ENABLED: boolean;
FEATURE_TSP_SYNC_ENABLED: boolean;
}

Expand Down Expand Up @@ -307,6 +308,7 @@ const config: ServerConfig = {
FEATURE_SANIS_GROUP_PROVISIONING_ENABLED: Configuration.get('FEATURE_SANIS_GROUP_PROVISIONING_ENABLED') as boolean,
FEATURE_AI_TUTOR_ENABLED: Configuration.get('FEATURE_AI_TUTOR_ENABLED') as boolean,
FEATURE_ROOMS_ENABLED: Configuration.get('FEATURE_ROOMS_ENABLED') as boolean,
FEATURE_ROOMS_CHANGE_PERMISSIONS_ENABLED: Configuration.get('FEATURE_ROOMS_CHANGE_PERMISSIONS_ENABLED') as boolean,
TSP_API_CLIENT_BASE_URL: Configuration.get('TSP_API_CLIENT_BASE_URL') as string,
TSP_API_CLIENT_TOKEN_LIFETIME_MS: Configuration.get('TSP_API_CLIENT_TOKEN_LIFETIME_MS') as number,
TSP_SYNC_SCHOOL_LIMIT: Configuration.get('TSP_SYNC_SCHOOL_LIMIT') as number,
Expand Down
5 changes: 5 additions & 0 deletions config/default.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1671,6 +1671,11 @@
"default": "false",
"description": "Enables the rooms feature"
},
"FEATURE_ROOMS_CHANGE_PERMISSIONS_ENABLED": {
"type": "boolean",
"default": "false",
"description": "Enables the ability to change permissions of room members"
},
"FEATURE_EXTERNAL_SYSTEM_LOGOUT_ENABLED": {
"type": "boolean",
"default": "false",
Expand Down
3 changes: 2 additions & 1 deletion config/development.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,5 +93,6 @@
"ALLOWED_API_KEYS": "thisisasupersecureapikeythatisabsolutelysave"
},
"TRAINING_URL": "https://lernen.dbildungscloud.de",
"FEATURE_ROOMS_ENABLED": true
"FEATURE_ROOMS_ENABLED": true,
"FEATURE_ROOMS_CHANGE_PERMISSIONS_ENABLED": true
}
Loading