-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-8547 - change room roles #5450
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Thomas Feldtkeller <[email protected]>
hoeppner-dataport
changed the title
Bc 8547 change room roles
BC-8547 - change room roles
Jan 21, 2025
apps/server/src/migrations/mikro-orm/Migration20250120131625.ts
Outdated
Show resolved
Hide resolved
apps/server/src/migrations/mikro-orm/Migration20250120131625.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/room-membership/service/room-membership.service.spec.ts
Show resolved
Hide resolved
apps/server/src/modules/room-membership/service/room-membership.service.ts
Outdated
Show resolved
Hide resolved
hoeppner-dataport
requested changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some smaller changes.
hoeppner-dataport
approved these changes
Jan 22, 2025
3 tasks
Quality Gate passedIssues Measures |
HKayed
pushed a commit
that referenced
this pull request
Jan 30, 2025
* endpoint to change the role of a roommember * can not be used to change the role of the owner * can not be used to assign the owner role * add ROOM_MEMBERS_CHANGE_ROLE to room admin and owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add endpoint to change the room-role of several room members to a specific role.
Links to Tickets or other pull requests
BC-8547
hpi-schul-cloud/nuxt-client#3518
Approval for review
generate-client:server
was executed in vue frontend and changes were tested and put in a PR with the same branch name.