locality: fix perf issue with long lines #2187
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note that the integration test failure is unrelated to this PR (it doesn't find lua 5.1 or something like that). |
2 tasks
emmanueltouzery
added a commit
to emmanueltouzery/nvim_config
that referenced
this pull request
Aug 28, 2025
|
also i did measure performance a little to pick the 5000... at 5000 it's instant for me. at 50.000 there is a little delay, <1s. at 250.000 it takes 5 seconds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1841
i also attempted to use vim.fn.matchstrpos to avoid the substring operations, but it seems it's not really the substring that's slow, but truly the regexes (or the populating of the locality map).
this is a very simple fix that solves a really problematic issue.