HLE auto log flag: Will let us entirely omit logging code from most syscalls, while still getting good logging. #19933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yscalls, while still getting good logging. Unfortunately, we do lose the file/line information if we do this. On the other hand, in every message like this, the HLE function name will be there, so maybe not a big deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, we do lose the file/line information if we do this.
On the other hand, in every message like this, the HLE function name will be there, so maybe not a big deal as you can easily search for it...
Advantages are that HLE functions become smaller and cleaner, plus it's easier to change how all HLE function logging behave as the logging becomes centralized.
Not all functions will be able to make use of this, like if you want to add extra information to the logging messages beyond the parameters and return value.
So, I'm not sure how good an idea this is...