Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glslang submodule #19952

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update glslang submodule #19952

wants to merge 1 commit into from

Conversation

oltolm
Copy link
Contributor

@oltolm oltolm commented Feb 5, 2025

This is also necessary to fix the GCC build.

@hrydgard
Copy link
Owner

hrydgard commented Feb 5, 2025

Can you explain why we need to add two submodules? Also, this didn't quite build.

@oltolm
Copy link
Contributor Author

oltolm commented Feb 6, 2025

I think they are needed by glslang now, I am not sure, I'll double check. It does not build for different reasons. On Windows I didn't add the new submodules to MSVC solution because I don't use it. On other systems that use CMake the problems are different.

@hrydgard
Copy link
Owner

hrydgard commented Feb 7, 2025

Well, I don't want to add code that we're not using. I'm doubtful this is needed since it's not needed on the other platforms. We carry all the headers and stuff we need in the current dependencies.

@oltolm
Copy link
Contributor Author

oltolm commented Feb 7, 2025

This is from glslang\CHANGES.md

## 14.1.0 2024-03-08
* Add SPIRV-Tools-opt dependency if ENABLE_OPT

If I disable ENABLE_OPT then CMake prints the warning

spirv-tools not linked - illegal SPIRV may be generated for HLSL

To disable this warning ENABLE_HLSL needs to be disabled.

option(ENABLE_HLSL "Enables HLSL input support" ON)

What should I do? Should I disable ENABLE_OPT and ENABLE_HLSL?

@hrydgard
Copy link
Owner

hrydgard commented Feb 10, 2025

ENABLE_HLSL should be disabled. We do not use HLSL as input to glslang currently.

In addition, ENABLE_OPT should also be fine to disable. Though it may be interesting to experiment with using it at some point.

@oltolm oltolm changed the title Update glslang submodule and add SPIRV-Tools and SPIRV-Headers submodules Update glslang submodule Feb 10, 2025
@hrydgard
Copy link
Owner

This PR still adds the submodules, please remove them.

@oltolm
Copy link
Contributor Author

oltolm commented Feb 10, 2025

I have removed them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants