-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update glslang submodule #19952
base: master
Are you sure you want to change the base?
Update glslang submodule #19952
Conversation
Can you explain why we need to add two submodules? Also, this didn't quite build. |
I think they are needed by glslang now, I am not sure, I'll double check. It does not build for different reasons. On Windows I didn't add the new submodules to MSVC solution because I don't use it. On other systems that use CMake the problems are different. |
Well, I don't want to add code that we're not using. I'm doubtful this is needed since it's not needed on the other platforms. We carry all the headers and stuff we need in the current dependencies. |
This is from
If I disable
To disable this warning
What should I do? Should I disable |
ENABLE_HLSL should be disabled. We do not use HLSL as input to glslang currently. In addition, ENABLE_OPT should also be fine to disable. Though it may be interesting to experiment with using it at some point. |
This PR still adds the submodules, please remove them. |
I have removed them. |
This is also necessary to fix the GCC build.