edit match function when assigning weights

[MikeJSeo]

Hi @gravesti,
can you merge this one and the other two

[github-actions]

Code Coverage Summary

Filename               Stmts    Miss  Cover    Missing
-------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------------------------------
R/binary-helper.R         72       7  90.28%   14, 18, 21, 24, 28, 31, 36
R/bucher.R                62       5  91.94%   103, 107, 111, 186-187
R/maic_anchored.R        499      46  90.78%   93-100, 105-108, 112, 115, 119, 122-125, 128-131, 136, 141, 144, 157, 166-171, 226, 306, 312, 317-321, 554, 560, 565-569
R/maic_unanchored.R      301      36  88.04%   85-92, 95-96, 101, 104-107, 110-113, 118, 127, 130, 143, 157-164, 193, 259, 266, 268, 414, 421, 423
R/matching.R             251      25  90.04%   73-75, 83, 104, 131, 152, 188, 227, 282-283, 295-296, 335, 352, 411-412, 500-504, 546-548
R/plot_km.R              450      46  89.78%   56, 59, 62, 81-111, 302, 305-307, 322-325, 357, 413, 493, 496, 499, 511-512
R/plot_km2.R             109      23  78.90%   53, 62, 65, 68, 77, 94-100, 127-135, 138, 186
R/process_data.R         102      22  78.43%   45, 60-63, 69, 81-82, 162, 200, 245-261
R/survival-helper.R       30       1  96.67%   61
R/time-helper.R           20       3  85.00%   31, 57-58
R/utils.R                 24       9  62.50%   11-20
R/zzz.R                    1       1  0.00%    2
TOTAL                   1921     224  88.34%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 2f8f61d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

  1 files  10 suites   6s ⏱️
 42 tests 34 ✅  8 💤 0 ❌
105 runs  88 ✅ 17 💤 0 ❌

Results for commit 2f8f61d.

♻️ This comment has been updated with latest results.

[gravesti]

Thanks for catching this @MikeJSeo . It would be good to add a test so we know this is stays fixed

[github-actions]

Unit Test Performance Difference

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
maic_unanchored	👶		$+0.04$	check_if_match_properly

Results for commit 2843daf

♻️ This comment has been updated with latest results.

[MikeJSeo]

Just FYI, here's the code I tried:

a <- data.frame(USUBJID = c(1,2,4,3,5))
b <- data.frame(USUBJID = c(5,2,1,3,4), weights = c(0.6,0.7,0.8,0.9, 0.1))

a$weights <- b$weights[match(b$USUBJID, a$USUBJID)]
a$weights <- b$weights[match(a$USUBJID, b$USUBJID)]

[gravesti]

Thanks @MikeJSeo !