-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve layout avoid covering the buttons on low resolution devices #20
Conversation
kaisar945
commented
Mar 1, 2024
- Before
- After
…-resolution devices
Oh, interesting! Thanks for the contribution @kaisar945, excellent point. I do agree this is better than the current behaviour here where the buttons disappear, although it would be nice if there was no need to scroll, and we do have some unnecessary whitespace left here... Do you think it's easy to shrink the whitespace (e.g. above the Connected text) just on small screens, to help with this? I think we'd want to use the scrollview too just as a backup for really small cases, but it would be nice to avoid needing that where possible. Out of interest, what device are you using where you're seeing this, and what's the resolution? I thought I'd tested most common small sizes, but this is clearly smaller than I was expecting. |
Thank you for your reply, you are right I will try it. This is my device resolution, it's not a real phone Physical size: 480x960 |
I'm still interested in this! Do you think you'll have any time soon to investigate tweaking the whitespace here? |
Of course, I've been busy with work recently and almost forgot about this. I'll take some time to fix it as soon as possible. |
Updated. |
Thanks @kaisar945! Merged and released as v1.3.11 (building now, it'll be live on Google Play and auto-downloaded in HTTP Toolkit within a day or so) |
By the way, in case you're not aware, HTTP Toolkit Pro is free for contributors - I've set up an account linked to your Git commit email (j*.j*@gmail.com). Just click 'Get Pro' then 'Log into existing account' and enter your email there to log in. Thanks again! |
Thank you for providing a powerful tool😃 |