Skip to content

Conversation

@LPardue
Copy link
Contributor

@LPardue LPardue commented Dec 11, 2025

I found this a little difficult to integrate in and hence its quite a mouthful of some sentences. However, I think it captures what was described in the issue.

Fixes #3356

Copy link
Member

@mikewest mikewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with your text, but I took a stab at changing some of the words. Hopefully it transforms your text in a way that improves scannability "without loss of information"? :)

If you prefer your original text, land it!

Comment on lines 237 to 241
information", that doesn't necessarily mean a byte-for-byte equivalence. Many
registered content codings do provide equivalence but there is no requirement
for it; it remains a possibility that decoding could produce a different byte
sequence. In order to avoid unintended validation failures, care is advised when
selecting content coding for use with `Unencoded-Digest`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about this suggestion?

Suggested change
information", that doesn't necessarily mean a byte-for-byte equivalence. Many
registered content codings do provide equivalence but there is no requirement
for it; it remains a possibility that decoding could produce a different byte
sequence. In order to avoid unintended validation failures, care is advised when
selecting content coding for use with `Unencoded-Digest`.
information", that doesn't necessarily mean a byte-for-byte equivalence. It's
entirely possible for content codings to perform semantically-meaningless
transformations that nevertheless result in a decoded byte sequence that does
not exactly match the original unencoded representation.In order to avoid
unintended validation failures, care is advised when selecting content coding
for use with `Unencoded-Digest`.

Copy link
Contributor Author

@LPardue LPardue Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry that this maybe makes the risk sound too large. I think Julian identified one content coding that behaves that way, and I don't think its widely used that. I hope that implementers of the spec can just assume things like gzip, brotli etc can be used without issues. I'll make a hybrid change that incorporates some of your proposed text.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL a look at the latest version after I pushed a commit.

Copy link
Contributor

@MikeBishop MikeBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either version works for me.

Copy link
Contributor

@MikeBishop MikeBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this help to further scope the size of the risk? It's worth calling out for completeness, but in practice most will be byte-for-byte unless they're media-type-specific.

LPardue and others added 2 commits December 11, 2025 21:47
Co-authored-by: Mike Bishop <[email protected]>
Co-authored-by: Mike Bishop <[email protected]>
@LPardue
Copy link
Contributor Author

LPardue commented Dec 11, 2025

With the two applied suggestions, I think that it strikes a decent balance on identifying the scope of risk, without being overlying rabbitholing

@LPardue
Copy link
Contributor Author

LPardue commented Dec 12, 2025

In the interest of moving forward, I'll merge this and cut a new release. We can continue to wordsmith up until publication if its really necessary.

Thanks for the input!

@LPardue LPardue merged commit 2ae9e90 into main Dec 12, 2025
2 checks passed
@LPardue LPardue deleted the lucas/fix-3356 branch December 12, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Section 5, paragraph 2

4 participants