-
Notifications
You must be signed in to change notification settings - Fork 166
Use table for comparison examples #3371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@martinthomson Does this address your concern from #3273? |
|
This should help. I don't know if this will present better in reality though, the URLs are all quite long, so there's a good chance that the whole thing will wrap badly. Maybe consider eliminating or truncating the origin part. |
75cb4b1 to
d4be317
Compare
It looks like the wrapping isn't too bad, but I've removed the rest of the URI so we just have the query now (and adjusted the column width so there isn't wrapping). Does that look any better to you? |
draft-ietf-httpbis-no-vary-search.md
Outdated
| </dt> | ||
| <dd><tt>+</tt> and <tt>%20</tt> are both parsed as U+0020 SPACE</dd> | ||
| </dl> | ||
| | Query A | Query B | Reason for Equivalence | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that you need the stuff.
This is what I get with it:
+===================+==============+============================+
| Query A | Query | Reason for Equivalence |
| | B | |
+===================+==============+============================+
| null | ? | A null query is parsed the |
| | | same as an empty string |
+-------------------+--------------+----------------------------+
| ?a=x | ?%61=%78 | Parsing performs percent- |
| | | decoding |
+-------------------+--------------+----------------------------+
| ?a=é | ?a=%C3%A9 | Parsing performs percent- |
| | | decoding |
+-------------------+--------------+----------------------------+
| ?a=%f6 | ?a=%ef%bf%bd | Both values are parsed as |
| | | U+FFFD (�) |
+-------------------+--------------+----------------------------+
| ?a=x&&&& | ?a=x | Parsing splits on & and |
| | | discards empty strings |
+-------------------+--------------+----------------------------+
| ?a= | ?a | Both parse as having an |
| | | empty string value for a |
+-------------------+--------------+----------------------------+
| ?a=%20 | ?a= & | %20 is parsed as U+0020 |
| | | SPACE |
+-------------------+--------------+----------------------------+
| ?a=+ | ?a= & | + is parsed as U+0020 |
| | | SPACE |
+-------------------+--------------+----------------------------+
And without:
+==========+==============+============================+
| Query A | Query B | Explanation |
+==========+==============+============================+
| null | ? | A null query is parsed the |
| | | same as an empty string |
+----------+--------------+----------------------------+
| ?a=x | ?%61=%78 | Parsing performs percent- |
| | | decoding |
+----------+--------------+----------------------------+
| ?a=é | ?a=%C3%A9 | Parsing performs percent- |
| | | decoding |
+----------+--------------+----------------------------+
| ?a=%f6 | ?a=%ef%bf%bd | Both values are parsed as |
| | | U+FFFD (�) |
+----------+--------------+----------------------------+
| ?a=x&&&& | ?a=x | Parsing splits on & and |
| | | discards empty strings |
+----------+--------------+----------------------------+
| ?a= | ?a | Both parse as having an |
| | | empty string value for a |
+----------+--------------+----------------------------+
| ?a=%20 | ?a= & | %20 is parsed as U+0020 |
| | | SPACE |
+----------+--------------+----------------------------+
| ?a=+ | ?a= & | + is parsed as U+0020 |
| | | SPACE |
+----------+--------------+----------------------------+
I think that the latter is better.
| | Query A | Query B | Reason for Equivalence | | |
| | Query A | Query B | Explanation | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated to remove some of the extra spaces in the first column, so if you look at the generated HTML, this is what it looks like with:

and what it looks like without any :

The first one seemed preferable, and generated .txt version looks okay too:
+===========+===================+============================+
| Query A | Query B | Explanation |
+===========+===================+============================+
| null | ? | A null query is parsed the |
| | | same as an empty string |
+-----------+-------------------+----------------------------+
| ?a=x | ?%61=%78 | Parsing performs percent- |
| | | decoding |
+-----------+-------------------+----------------------------+
| ?a=é | ?a=%C3%A9 | Parsing performs percent- |
| | | decoding |
+-----------+-------------------+----------------------------+
| ?a=%f6 | ?a=%ef%bf%bd | Both values are parsed as |
| | | U+FFFD (�) |
+-----------+-------------------+----------------------------+
| ?a=x&&&& | ?a=x | Parsing splits on & and |
| | | discards empty strings |
+-----------+-------------------+----------------------------+
| ?a= | ?a | Both parse as having an |
| | | empty string value for a |
+-----------+-------------------+----------------------------+
| ?a=%20 | ?a= & | %20 is parsed as U+0020 |
| | | SPACE |
+-----------+-------------------+----------------------------+
| ?a=+ | ?a= & | + is parsed as U+0020 |
| | | SPACE |
+-----------+-------------------+----------------------------+
|
FWIW: puttig nbsps into the source code to optimize HTML output sounds very wrong (this is an xml2rfc/kramdown comment). It should not be needed. |
|
I agree with Julian. Have you considered "First Query", "Second Query"? |
|
It's a CSS issue, at least in part. xml2rfc will do the same if the window is narrow enough. The problem is a lack of a means of signaling that you want less wrapping. You can avoid the wrapping with less text in the third column, a wider table, or many other things. But what we really need is something like a wrap-avoiding span element. |
|
Thanks for the feedback, just merged #3381 to remove the |

Fixes #3273.