-
Notifications
You must be signed in to change notification settings - Fork 104
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'main' of github.com:gerritbehrens/showtime-website
- Loading branch information
Showing
31 changed files
with
425 additions
and
339 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
|
||
### Opening a Pull Request to Update your Project | ||
|
||
Please follow these Steps & Guidelines for your Pull Request: | ||
|
||
#### Before you Request a Review Check and Tick these Boxes: | ||
|
||
[] make sure that the hugo site build works and check the result visually. | ||
[] merge your local branch with upstream/main (see [update doc](https://github.com/htw-imi-showtime/showtime-website/blob/main/doc/update.md)) | ||
[] Deploy the Site on your github pages by activating the "Deploy Page using GH-Actions" Workflow in "gh-pages-action.yml" | ||
[] make sure that your PR contains only files / file changes within your project subdirectory. | ||
[] make sure that all your file names consist only of lower case letters, numbers, or [-_.] - with only one . for the file extension | ||
[] delete all unnecessary files from your PR (including cat.jpg and kitty.jpg) | ||
[] check the image file sizes. All Images have to be as small as possible. See [./doc/disk_usage.md](./doc/disk_usage.md) about this issues, there's a script: [./bin/images-smaller.sh](./bin/images-smaller.sh) | ||
|
||
**Note that if you fail to do so, I may simply reduce the file sizes brute force using | ||
the script above - WITHOUT CHECKING THE QUALITY** | ||
|
||
[] if everythings seems fine, request a review by bkleinen on github. (on the upper right) | ||
|
||
#### Fill out this Information: | ||
|
||
1. Change the PR Title to: <project-id> <describe your changes> (e.g. B0 - update techstack.md) and describe your changes: | ||
|
||
|
||
2. URL of your Preview Site Containing the Changes: | ||
|
||
|
||
3. When did your Project Supervisor review your changes? (Date/Note or require review for PR): | ||
|
||
|
||
4. If your disk usage exceeds 500K, provide a reason while you want to include so many images or why certain images need to be that big: | ||
|
||
|
||
|
||
#### All good? Request a Review! | ||
|
||
[] if everythings seems fine, request a review by bkleinen on github. (on the upper right) | ||
|
||
|
||
### More Information | ||
|
||
- [Best Practices for Pull Requests](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/getting-started/best-practices-for-pull-requests) | ||
|
||
- Documentation in README.MD and /doc |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.