Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B4:Bilder hinzugefügt #355

Closed
wants to merge 32 commits into from

Conversation

EldarAkh04
Copy link
Contributor

No description provided.

@bkleinen
Copy link
Contributor

bkleinen commented Jul 2, 2024

Bitte Review Requesten wenn Sie soweit sind.
(ich hatte die Dateigrößen reduziert, ist es wirklich notwendig, sie wieder soweit zu vergrößern? https://github.com/htw-imi-showtime/showtime-website/pull/355/files )

@bkleinen
Copy link
Contributor

bkleinen commented Jul 6, 2024

Hallo! Damit ich nicht immer die gleichen Sachen in den PR kommentieren muss, habe ich das jetzt größtenteils automatisiert. Zunächst habe ich versehentlich in Ihr repo gepusht - offensichtlich habe ich Schreibrechte - und mich jetzt entschieden, main vollständig zu mergen, so dass dieser Schritt erstmal schon erledigt ist. Danke für den guten Testfall :) ;-)

--- dies wird ab jetzt in jeden neuen PR kopiert, Sie können einfach hier weitermachen: (falls Sie hier nicht editieren können oder falls beim kopieren die Formatierung kaputt geht: https://raw.githubusercontent.com/htw-imi-showtime/showtime-website/main/.github/pull_request_template.md (in neuen Kommentar kopieren und bearbeiten)

Opening a Pull Request to Update your Project

Please follow these Steps & Guidelines for your Pull Request:

Before you Open the Pull Request Check and Tick these Boxes:

[x] Before you open the PR, make sure that the hugo site build works and check the result visually.
[x] Before you open the PR, merge your local branch with upstream/main (see update doc)
[] Deploy the Site on your github pages by activating the "Deploy Page using GH-Actions" Workflow in "gh-pages-action.yml"
[] make sure that your PR contains only files / file changes within your project subdirectory.
[] make sure that all your file names consist only of lower case letters, numbers, or [-_.] - with only one . for the file extension
[] delete all unnecessary files from your PR (including cat.jpg and kitty.jpg)
[] check the image file sizes. All Images have to be as small as possible. See ./doc/disk_usage.md about this issues, there's a script: ./bin/images-smaller.sh

Note that if you consistently fail to do so, I may simply reduce the file sizes brute force using
the script above - WITHOUT CHECKING THE QUALITY

[] if everythings seems fine, request a review by bkleinen on github. (on the upper right)

Fill out this Information:

  1. Change the PR Title to: (e.g. B0 - update techstack.md) and describe your changes:

  2. URL of your Preview Site Containing the Changes:

  3. When did your Project Supervisor review your changes? (Date/Note or require review for PR):

  4. If your disk usage exceeds 500K, provide a reason while you want to include so many images or why certain images need to be that big:

More Information

Copy link
Contributor

@bkleinen bkleinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing checks below and fill out the new PR template in the comment above.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich hatte Ihre Projekt-Metadaten verbessert. Ich nehme an, Sie haben einfach Ihre ursprüngliche Version über meine Änderungen kopiert?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ich hatte auch kitty.jpg und cat.jpg schonmal gelöscht...

@EldarAkh04 EldarAkh04 changed the title Neuen Branch erstellt B4:Bilder hinzugefügt Jul 11, 2024
@bkleinen
Copy link
Contributor

decided to merge #383 - closing this as duplicate

@bkleinen bkleinen closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants