Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B4 fix pr 361 - This builds on the patch-1 branch of your repo. #363

Closed
wants to merge 30 commits into from

Conversation

bkleinen
Copy link
Contributor

Opening a Pull Request to Update your Project

Please follow these Steps & Guidelines for your Pull Request:

Before you Request a Review Check and Tick these Boxes:

[] make sure that the hugo site build works and check the result visually.
[] merge your local branch with upstream/main (see update doc)
[] Deploy the Site on your github pages by activating the "Deploy Page using GH-Actions" Workflow in "gh-pages-action.yml"
[] make sure that your PR contains only files / file changes within your project subdirectory.
[] make sure that all your file names consist only of lower case letters, numbers, or [-_.] - with only one . for the file extension
[] delete all unnecessary files from your PR (including cat.jpg and kitty.jpg)
[] check the image file sizes. All Images have to be as small as possible. See ./doc/disk_usage.md about this issues, there's a script: ./bin/images-smaller.sh

Note that if you fail to do so, I may simply reduce the file sizes brute force using
the script above - WITHOUT CHECKING THE QUALITY

[] if everythings seems fine, request a review by bkleinen on github. (on the upper right)

Fill out this Information:

  1. Change the PR Title to: (e.g. B0 - update techstack.md) and describe your changes:

  2. URL of your Preview Site Containing the Changes:

  3. When did your Project Supervisor review your changes? (Date/Note or require review for PR):

  4. If your disk usage exceeds 500K, provide a reason while you want to include so many images or why certain images need to be that big:

All good? Request a Review!

[] if everythings seems fine, request a review by bkleinen on github. (on the upper right)

More Information

We are using the Forking Workflow.

@bkleinen
Copy link
Contributor Author

I will fix my script. As Paul.jpg was deleted, it turns up in the list of changed files.

@bkleinen
Copy link
Contributor Author

bkleinen commented Jul 12, 2024

Damit die Checks laufen, habe ich mein sehr radikales Verkleinerungsscript angewandt.
Ich habe mein file name convention-script verbessert, so dass nur noch vorhandene, nicht gelöschte Dateinamen berücksichtigt werden (und den rest der .JPG umbenannt...)

Allerdings ist nach wie vor die regression enthalten, dass meine verbesserungen im project-meta überschreiben wurden:

image

@bkleinen
Copy link
Contributor Author

bkleinen commented Jul 12, 2024

das waren meine Änderungen:

 +++
 project_id = "B4"
-title = "SEMPY AI-Research Agent"
-subtitle = ""
-claim = ""
+title = "Sempy"
+subtitle = "AI-Research Agent"
+claim = "SEMPY is an AI-Research Agent that supports customers of the idealo website to help them make better buying decission. This is tool takes different information from different websites and summarizes them and gives the best advice."
 abstract = ""
 
 # Properties for displaying the project in the project list
 card_image = "Logo.jpg"
 # card_description is deprecated, will be replaced by abstract/and or claim
-card_description = "SEMPY is an AI research agent that supports customers of the idealo website in making better buying decisions. This tool gathers information from various websites, summarizes it, and provides the best advice." 
+card_description = "" 
 
 # Names are optional, team size is sufficient
 team = ["Son Xuan Hoang","Eldar Akhundzada", "Mathieu Wassmuth", "Paul Schiffner", "Yasin Dalowar"]
-supervisor = "Jakob Panten & Jana Dolan & Tino Nitze"
+supervisor = ["Jakob Panten", "Jana Dolan", "Tino Nitze"]
 draft = false
 
 website_link = ""
 source_link = ""
 
+tags = ["ai"]
+categories = ["External Stakeholder"]
+study_focus = ['Web Technology']
 +++
 

@bkleinen bkleinen assigned bkleinen and unassigned bkleinen Jul 12, 2024
@bkleinen bkleinen mentioned this pull request Jul 12, 2024
@bkleinen
Copy link
Contributor Author

decided to merge #383 - closing this as duplicate

@bkleinen bkleinen closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants