[1284] support nacos service metadata #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provenceee
force-pushed
the
metadata-master
branch
from
505d455
to
b097413
Compare
chengyouling
approved these changes
Jun 26, 2024
liubao68
reviewed
Jun 26, 2024
Comment on lines
+73
to
+77
| NamingMaintainService namingMaintainService = namingMaintainService(); | ||
| try { | ||
| namingService.registerInstance(serviceId, group, instance); | ||
| namingMaintainService.updateService(serviceId, group, 0, | ||
| NacosMicroserviceHandler.createMicroserviceMetadata()); |
There was a problem hiding this comment.
是否可以注册的时候就设置属性？而不是先注册再更新？
There was a problem hiding this comment.
注册实例的时候无法设置服务级的元数据，如果注册实例之前设置服务级的元数据，需要判断是否存在服务，存在就更新，不存在要创建，所以这里选择注册时候后去更新
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.