Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dws): add new resource and datasource to manage schema space management #5546

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wuzhuanhong
Copy link
Contributor

What this PR does / why we need it:

Add new resource to modify schema space limit.
Add new dataSource to query the list of the schema space information.
Add relates documents and acceptance test.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

This is a one-time resource, so it does not involve CheckDeleted.

PR Checklist

  • Tests added/passed.
make testacc TEST=./huaweicloud/services/acceptance/dws TESTARGS='-run TestAccDataSourceSchemaSpaceManagements_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dws -v -run TestAccDataSourceSchemaSpaceManagements_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceSchemaSpaceManagements_basic
=== PAUSE TestAccDataSourceSchemaSpaceManagements_basic
=== CONT  TestAccDataSourceSchemaSpaceManagements_basic
--- PASS: TestAccDataSourceSchemaSpaceManagements_basic (76.72s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dws       76.777s```

* [x] Documentation updated.
* [x] Schema updated.
* [ ] CheckDeleted.

  - **a. During query operation (Read Context)**
    aa. Resource not found
    \>>>>>> Paste the screenshot here <<<<<<

    <!-- If the resource depends the parent resource(s), please provide the related check result(s) of the CheckDeleted validation.
    ab. Related resources (parent resources) not found
    \>>>>>> Paste the screenshot here <<<<<<
    -->
  - **b. During delete/disassociate/unbind operation (Delete Context)**
    ba. Resource not found
    \>>>>>> Paste the screenshot here <<<<<<

    <!-- If the resource depends the parent resource(s), please provide the related check result(s) of the CheckDeleted validation.
    bb. Related resources (parent resources) not found
    \>>>>>> Paste the screenshot here <<<<<<
    -->

)
client, err := cfg.NewServiceClient("dws", cfg.GetRegion(d))
if err != nil {
return diag.Errorf("error creating DWS Client: %s", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return diag.Errorf("error creating DWS Client: %s", err)
return diag.Errorf("error creating DWS client: %s", err)

@wuzhuanhong
Copy link
Contributor Author

make testacc TEST=./huaweicloud/services/acceptance/dws TESTARGS='-run TestAccDataSourceSchemaSpaceManagements_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dws -v -run TestAccDataSourceSchemaSpaceManagements_basic -timeout 360m -parallel 4
=== RUN TestAccDataSourceSchemaSpaceManagements_basic
=== PAUSE TestAccDataSourceSchemaSpaceManagements_basic
=== CONT TestAccDataSourceSchemaSpaceManagements_basic
--- PASS: TestAccDataSourceSchemaSpaceManagements_basic (97.00s)
PASS
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dws 97.062s

@dengyali0125
Copy link

LGTM

1 similar comment
@WangLiNaruto
Copy link

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants