Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workspace/app): add data source to get list of the image servers #5922

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wuzhuanhong
Copy link
Contributor

What this PR does / why we need it:

Add new datasource to get the list of the image server of the Workspace APP.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. add new datasource to get image servers.
2. add correponding document and acceptance test.

PR Checklist

  • Tests added/passed.
$ ./scripts/coverage.sh -o workspace -f TestAccDataSourceAppImageServers_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDataSourceAppImageServers_basic -timeout 360m -parallel 10
=== RUN   TestAccDataSourceAppImageServers_basic
=== PAUSE TestAccDataSourceAppImageServers_basic
=== CONT  TestAccDataSourceAppImageServers_basic
--- PASS: TestAccDataSourceAppImageServers_basic (864.69s)
PASS
coverage: 7.6% of statements in ./huaweicloud/services/workspace
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 864.776s        coverage: 7.6% of statements in ./huaweicloud/services/workspace
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@wuzhuanhong wuzhuanhong force-pushed the image_servers branch 2 times, most recently from d5ce381 to 6ba8e37 Compare November 27, 2024 08:44
@wuzhuanhong
Copy link
Contributor Author

./scripts/coverage.sh -o workspace -f TestAccDataSourceAppImageServers_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDataSourceAppImageServers_basic -timeout 360m -parallel 10
=== RUN TestAccDataSourceAppImageServers_basic
=== PAUSE TestAccDataSourceAppImageServers_basic
=== CONT TestAccDataSourceAppImageServers_basic
--- PASS: TestAccDataSourceAppImageServers_basic (833.15s)
PASS
coverage: 6.5% of statements in ./huaweicloud/services/workspace
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 833.255s coverage: 6.5% of statements in ./huaweicloud/services/workspace

@wuzhuanhong
Copy link
Contributor Author

./scripts/coverage.sh -o workspace -f TestAccDataSourceAppImageServers_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDataSourceAppImageServers_basic -timeout 360m -parallel 10
=== RUN TestAccDataSourceAppImageServers_basic
=== PAUSE TestAccDataSourceAppImageServers_basic
=== CONT TestAccDataSourceAppImageServers_basic
--- PASS: TestAccDataSourceAppImageServers_basic (956.65s)
PASS
coverage: 6.5% of statements in ./huaweicloud/services/workspace
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 956.721s coverage: 6.5% of statements in ./huaweicloud/services/workspace

@WangLiNaruto
Copy link

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants