Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CSS): add css restore resource #5928

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

InsaneTimeWatcher
Copy link

What this PR does / why we need it:

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

add css restore resource

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST=./huaweicloud/services/acceptance/css/ TESTARGS='-run TestAccCssInstanceRestore_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/css/ -v -run TestAccCssInstanceRestore_ -timeout 360m -parallel 4
=== RUN   TestAccCssInstanceRestore_basic
=== PAUSE TestAccCssInstanceRestore_basic
=== CONT  TestAccCssInstanceRestore_basic
--- PASS: TestAccCssInstanceRestore_basic (1213.43s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/css       1213.591s

@andreilapkin
Copy link

Is anyone working on merging this feature into master?

@lutartur
Copy link

lutartur commented Dec 6, 2024

very convenient for flexible setup of different stands/environments
@houpeng80 @saf3dfsa @deer-hang @luoping-12345

@kolt2050
Copy link

kolt2050 commented Dec 6, 2024

this will help my team a lot

@@ -2228,6 +2228,7 @@ func Provider() *schema.Provider {

"huaweicloud_cdm_cluster_v1": cdm.ResourceCdmCluster(),
"huaweicloud_css_cluster_v1": css.ResourceCssCluster(),
"huaweicloud_css_restore": css.ResourceCssRestore(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move it to line 1480-1498

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be to 1464? after huaweicloud_css_snapshot

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

---
subcategory: "Cloud Search Service (CSS)"
layout: "huaweicloud"
page_title: "HuaweiCloud: huaweicloud_css_restore"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource name suggest to be huaweicloud_css_snapshot_restore

InsaneTimeWatcher and others added 3 commits December 10, 2024 23:30
change to string

Co-authored-by: CaiWanting <[email protected]>
fix typo

Co-authored-by: CaiWanting <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants