Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CodeArts/Deploy): fix check delete and change url for host #6049

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saf3dfsa
Copy link
Contributor

@saf3dfsa saf3dfsa commented Dec 18, 2024

What this PR does / why we need it:
fix check delete for it's no longer return 200 when request failed
change url for old API is no longer maintained

PR Checklist

  • Tests added/passed.
make testacc TEST="./huaweicloud/services/acceptance/codeartsdeploy" TESTARGS="-run TestAccDeployHost_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/codeartsdeploy -v -run TestAccDeployHost_ -timeout 360m -parallel 4
=== RUN   TestAccDeployHost_withProxyMode
=== PAUSE TestAccDeployHost_withProxyMode
=== RUN   TestAccDeployHost_withoutProxyMode
=== PAUSE TestAccDeployHost_withoutProxyMode
=== CONT  TestAccDeployHost_withProxyMode
=== CONT  TestAccDeployHost_withoutProxyMode
--- PASS: TestAccDeployHost_withoutProxyMode (343.30s)
--- PASS: TestAccDeployHost_withProxyMode (351.11s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/codeartsdeploy    351.217s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<
      image

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<
      image

@saf3dfsa saf3dfsa changed the title fix(CodeArts/deploy): fix check delete and change url for host fix(CodeArts/Deploy): fix check delete and change url for host Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant