Cde create visualization page #340

edlu77 · 2024-04-02T17:30:48Z

nx-cloud · 2024-04-02T17:31:46Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 06847ff. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
`nx affected --target=test --parallel=3 --exclude=tag:karma-test-runner --ci --code-coverage`

✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

axdanbol

Best practices and some changes

apps/cde-ui/src/app/pages/create-visualization-page/create-visualization-page.component.html

apps/cde-ui/src/app/pages/create-visualization-page/create-visualization-page.component.ts

apps/cde-ui/src/app/pages/create-visualization-page/create-visualization-page.component.html

apps/cde-ui/src/app/pages/create-visualization-page/create-visualization-page.component.ts

apps/cde-ui/src/assets/background.png

apps/cde-ui/src/assets/background.png:Zone.Identifier

apps/cde-ui/src/index.html

axdanbol · 2024-04-02T19:16:18Z

Please pull and resolve conflicts from cell-distance-explorer. Doing so will allow ci and preview scripts to run.

…sortium/hra-ui into cde-create-visualization-page

github-actions · 2024-04-02T22:30:12Z

🚀 Preview Deploy Report Updated

✅ Successfully deployed preview here

…sortium/hra-ui into cde-create-visualization-page

apps/cde-ui/src/_redirects

apps/cde-ui/src/app/app.config.ts

apps/cde-ui/src/app/pages/create-visualization-page/create-visualization-page.component.html

apps/cde-ui/src/app/pages/create-visualization-page/create-visualization-page.component.ts

…sortium/hra-ui into cde-create-visualization-page

apps/cde-ui/project.json

apps/cde-ui/src/app/models/create-visualization-page-types.ts

apps/cde-ui/src/app/pages/create-visualization-page/create-visualization-page.component.html

apps/cde-ui/src/app/services/service.ts

apps/cde-ui/src/assets/TEMP/mock-cell-type-data.csv

apps/cde-ui/src/assets/fonts/fonts.scss

apps/cde-ui/src/app/services/service.mock.ts

apps/cde-ui/src/app/pages/create-visualization-page/create-visualization-page.component.ts

…sortium/hra-ui into cde-create-visualization-page

apps/cde-ui/src/app/pages/create-visualization-page/create-visualization-page.component.html

axdanbol · 2024-04-17T15:16:33Z

apps/cde-ui/src/app/pages/create-visualization-page/create-visualization-page.component.html

+      </mat-card-title>
+    </mat-card-header>
+    <mat-card-actions>
+      <div class="row-1">


Use a hidden element after age input on larger breakpoints

axdanbol · 2024-04-17T15:17:04Z

apps/cde-ui/src/app/pages/create-visualization-page/create-visualization-page.component.html

+      </mat-card-title>
+    </mat-card-header>
+    <mat-card-actions>
+      <div class="row-1">


Use flex with flex-wrap

apps/cde-ui/src/app/pages/create-visualization-page/create-visualization-page.component.html

apps/cde-ui/src/app/pages/create-visualization-page/create-visualization-page.component.ts

apps/cde-ui/src/app/pages/create-visualization-page/create-visualization-page.component.html

apps/cde-ui/src/app/pages/create-visualization-page/create-visualization-page.component.ts

apps/cde-ui/src/app/services/file-upload-service.ts

apps/cde-ui/src/app/services/test.csv

…sortium/hra-ui into cde-create-visualization-page

sonarcloud · 2024-05-16T21:43:31Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

edlu77 added 2 commits April 1, 2024 18:47

Make initial page outline

7252449

Styling and fonts

9754423

edlu77 requested review from axdanbol and bherr2 April 2, 2024 17:30

edlu77 self-assigned this Apr 2, 2024

axdanbol changed the base branch from develop to cell-distance-explorer April 2, 2024 18:19

Fix build targets

adaf132

axdanbol requested changes Apr 2, 2024

View reviewed changes

Merge branch 'cell-distance-explorer' of https://github.com/hubmapcon…

aa3f7db

…sortium/hra-ui into cde-create-visualization-page

edlu77 added 10 commits April 2, 2024 18:42

Edit output path

27dfb9e

Switch to browser-esbuild

d155d74

Merge branch 'cell-distance-explorer' of https://github.com/hubmapcon…

156a685

…sortium/hra-ui into cde-create-visualization-page

Set up link to create visualization page

38c7932

Fix issues and update logic

74e420d

Merge branch 'cell-distance-explorer' of https://github.com/hubmapcon…

d810ef9

…sortium/hra-ui into cde-create-visualization-page

Update package-lock.json

8e3de2f

Improvements

38fed02

Merge branch 'cell-distance-explorer' of https://github.com/hubmapcon…

50c295c

…sortium/hra-ui into cde-create-visualization-page

Update package-lock.json

0c74468

axdanbol requested changes Apr 4, 2024

View reviewed changes

edlu77 added 5 commits April 4, 2024 18:56

Use reactive form controls

87a9e59

Move redirects file

bb25173

Add cell type data service

52a157f

Check if data is uploaded when submitting

e387421

Merge branch 'cell-distance-explorer' of https://github.com/hubmapcon…

4d8e542

…sortium/hra-ui into cde-create-visualization-page

axdanbol requested changes Apr 11, 2024

View reviewed changes

More changes

6200201

edlu77 added 5 commits April 12, 2024 16:44

Clean up and requested changes

e642958

Merge branch 'cell-distance-explorer' of https://github.com/hubmapcon…

e6e8bf8

…sortium/hra-ui into cde-create-visualization-page

Use signals for file upload service

b348eac

Some tweaks

149810a

Use formBuilder to create and validate form

8c65cc4

axdanbol requested changes Apr 17, 2024

View reviewed changes

axdanbol assigned bhushankhope Apr 17, 2024

bhushankhope and others added 2 commits April 17, 2024 11:40

create file upload component

bc74142

Merge branch 'cell-distance-explorer' into cde-create-visualization-page

aa48d95

axdanbol marked this pull request as ready for review April 17, 2024 19:42

bhushankhope added 4 commits April 19, 2024 13:19

update form and its css

95ddf87

create theme and modify cards

e1ba83d

add states to form field

eef7ed0

update background size

dde2ecc

axdanbol requested changes May 7, 2024

View reviewed changes

bhushankhope and others added 9 commits May 7, 2024 12:42

add tests for csv loader

f2bf822

add tests for create vis page

139a43c

add tests for form control directive

392f975

Merge branch 'cell-distance-explorer' into cde-create-visualization-page

8e04576

build(cde): 🔧 Increase style files max size

ff7e3c6

Merge branch 'cell-distance-explorer' of https://github.com/hubmapcon…

ad9090c

…sortium/hra-ui into cde-create-visualization-page

refactor(cde): ♻️ Post merge fixes

42d145a

docs(cde): 📝 Increase code doc coverage

635bc7a

refactor(cde): Fix import

06847ff

axdanbol merged commit c89d973 into cell-distance-explorer May 16, 2024
8 of 9 checks passed

axdanbol deleted the cde-create-visualization-page branch May 16, 2024 21:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cde create visualization page #340

Cde create visualization page #340

edlu77 commented Apr 2, 2024

nx-cloud bot commented Apr 2, 2024 •

edited

Loading

axdanbol left a comment

axdanbol commented Apr 2, 2024

github-actions bot commented Apr 2, 2024 •

edited

Loading

axdanbol Apr 17, 2024

axdanbol Apr 17, 2024

sonarcloud bot commented May 16, 2024

Cde create visualization page #340

Cde create visualization page #340

Conversation

edlu77 commented Apr 2, 2024

nx-cloud bot commented Apr 2, 2024 • edited Loading

☁️ Nx Cloud Report

axdanbol left a comment

Choose a reason for hiding this comment

axdanbol commented Apr 2, 2024

github-actions bot commented Apr 2, 2024 • edited Loading

🚀 Preview Deploy Report Updated

axdanbol Apr 17, 2024

Choose a reason for hiding this comment

axdanbol Apr 17, 2024

Choose a reason for hiding this comment

sonarcloud bot commented May 16, 2024

Quality Gate passed

nx-cloud bot commented Apr 2, 2024 •

edited

Loading

github-actions bot commented Apr 2, 2024 •

edited

Loading