Skunkworks 2024! #96
Merged
Skunkworks 2024! #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vstehlik
commented
Oct 23, 2024
vstehlik
commented
- Updates to dependencies
…darToSlack into SK24-UpdateDependencies
…darToSlack into SK24-UpdateDependencies
vstehlik
commented
Oct 23, 2024
vstehlik
commented
Oct 23, 2024
vstehlik
commented
Oct 23, 2024
…darToSlack into SK24-UpdateDependencies
vstehlik
commented
Oct 23, 2024
vstehlik
commented
Oct 23, 2024
src/services/slack.ts
Outdated
| @@ -46,7 +44,8 @@ export const setUserPresence = async (email: string, token: string | undefined, | |||
| const slackClient = new WebClient(token); | |||
|
|
|||
| try { | |||
| await slackClient.users.setPresence({ presence }); | |||
| const result = await slackClient.users.setPresence({ presence }); | |||
| throw result.error; | |||
There was a problem hiding this comment.
Do we want to throw the error or just log it?
There was a problem hiding this comment.
I think throwing is still good 🤔 The handleError function ends up checking the error message and if it's "token_revoked" or "invalid_auth" it clears the tokens and sends the user a message in Slack to re-auth.
There was a problem hiding this comment.
Does this need to be wrapped in a conditional statement then to only throw if there is an error?
There was a problem hiding this comment.
Swapped to the the response ok boolean and only throw if that's missing/false!
2079346
Co-authored-by: Val Stehlik <[email protected]>
ppoulsen
approved these changes
Oct 23, 2024
Co-authored-by: Val Stehlik <[email protected]>
SK24 - Update dependencies and migrate from yarn v1 to npm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.