Remove @on_main_process in init_trackers to fix tracker init error #3777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n error The @on_main_process decorator on init_trackers was preventing tracker initialization in non-main processes, leaving the trackers array empty. This caused accelerate.get_track() to return GeneralTracker for non-main processes, resulting in attribute errors like `'GeneralTracker' object has no attribute 'log_images'.` Since GeneralTracker and its subclasses already handle calls from non-main processes appropriately, the decorator was creating unintended behavior. Removing @on_main_process ensures init_trackers runs in all processes, maintaining proper tracker initialization and preventing these errors.
FrostMiKu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The @on_main_process decorator on init_trackers was preventing tracker initialization in non-main processes, leaving the trackers array empty. This caused accelerate.get_track() to return GeneralTracker for non-main processes, resulting in attribute errors like
'GeneralTracker' object has no attribute 'log_images'.Since GeneralTracker and its subclasses already handle calls from non-main processes appropriately, the decorator was creating unintended behavior. Removing @on_main_process ensures init_trackers runs in all processes, maintaining proper tracker initialization and preventing these errors.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.